Move DisplayItemList complex inline method implementations to .cpp.

third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DisplayItemList_h
 #define DisplayItemList_h
 
 #include "platform/graphics/ContiguousContainer.h"
 #include "platform/graphics/paint/DisplayItem.h"
 #include "platform/graphics/paint/Transform3DDisplayItem.h"
 #include "wtf/Alignment.h"
 #include "wtf/Assertions.h"
 
-#ifndef NDEBUG
-#include "wtf/text/WTFString.h"
-#endif
-
 namespace blink {
 
 struct PaintChunk;
 
 // kDisplayItemAlignment must be a multiple of alignof(derived display item) for
 // each derived display item; the ideal value is the least common multiple.
 // Currently the limiting factor is TransformationMatrix (in
 // BeginTransform3DDisplayItem), which requests 16-byte alignment.
 static const size_t kDisplayItemAlignment = WTF_ALIGN_OF(BeginTransform3DDisplayItem);
 static const size_t kMaximumDisplayItemSize = sizeof(BeginTransform3DDisplayItem);
@@ skipping 10 matching lines @@
     {}
 
     DisplayItemList& operator=(DisplayItemList&& source)
     {
         ContiguousContainer::operator=(std::move(source));
         m_visualRects = std::move(source.m_visualRects);
         m_beginItemIndices = std::move(source.m_beginItemIndices);
         return *this;
     }
 
-    DisplayItem& appendByMoving(DisplayItem& item, const IntRect& visualRect)
-    {
-#ifndef NDEBUG
-        WTF::String originalDebugString = item.asDebugString();
-#endif
-        ASSERT(item.hasValidClient());
-        DisplayItem& result = ContiguousContainer::appendByMoving(item, item.derivedSize());
-        // ContiguousContainer::appendByMoving() calls an in-place constructor
-        // on item which replaces it with a tombstone/"dead display item" that
-        // can be safely destructed but should never be used.
-        ASSERT(!item.hasValidClient());
-#ifndef NDEBUG
-        // Save original debug string in the old item to help debugging.
-        item.setClientDebugString(originalDebugString);
-#endif
-        appendVisualRect(visualRect);
-        return result;
-    }
+    DisplayItem& appendByMoving(DisplayItem&, const IntRect& visualRect);
 
     IntRect visualRect(unsigned index) const
     {
         ASSERT(index < m_visualRects.size());
         return m_visualRects[index];
     }
 
     void appendVisualRect(const IntRect& visualRect);
 
 #if ENABLE(ASSERT)
-    void assertDisplayItemClientsAreAlive() const
-    {
-        for (auto& item : *this) {
-#ifdef NDEBUG
-            DCHECK(DisplayItemClient::isAlive(item.client())) << "Short-lived DisplayItemClient. See crbug.com/570030.";
-#else
-            DCHECK(DisplayItemClient::isAlive(item.client())) << "Short-lived DisplayItemClient: " << item.clientDebugString() << ". See crbug.com/570030.";
-#endif
-        }
-    }
+    void assertDisplayItemClientsAreAlive() const;
 #endif
 
     // Useful for iterating with a range-based for loop.
     template <typename Iterator>
     class Range {
     public:
         Range(const Iterator& begin, const Iterator& end)
             : m_begin(begin), m_end(end) {}
         Iterator begin() const { return m_begin; }
         Iterator end() const { return m_end; }
     private:
         Iterator m_begin;
         Iterator m_end;
     };
     Range<iterator> itemsInPaintChunk(const PaintChunk&);
     Range<const_iterator> itemsInPaintChunk(const PaintChunk&) const;
 
 private:
     // If we're currently within a paired display item block, unions the
     // given visual rect with the begin display item's visual rect.
     void growCurrentBeginItemVisualRect(const IntRect& visualRect);
 
     Vector<IntRect> m_visualRects;
     Vector<size_t> m_beginItemIndices;
 };
 
 } // namespace blink
 
 #endif // DisplayItemList_h