Move DisplayItemList complex inline method implementations to .cpp.

third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/graphics/paint/DisplayItemList.h"
 
 #include "platform/graphics/paint/PaintChunk.h"
 
+#ifndef NDEBUG
+#include "wtf/text/WTFString.h"
+#endif
+
 namespace blink {
 
+DisplayItem& DisplayItemList::appendByMoving(DisplayItem& item, const IntRect& visualRect)
+{
+#ifndef NDEBUG
+    String originalDebugString = item.asDebugString();
+#endif
+    ASSERT(item.hasValidClient());
+    DisplayItem& result = ContiguousContainer::appendByMoving(item, item.derivedSize());
+    // ContiguousContainer::appendByMoving() calls an in-place constructor
+    // on item which replaces it with a tombstone/"dead display item" that
+    // can be safely destructed but should never be used.
+    ASSERT(!item.hasValidClient());
+#ifndef NDEBUG
+    // Save original debug string in the old item to help debugging.
+    item.setClientDebugString(originalDebugString);
+#endif
+    appendVisualRect(visualRect);
+    return result;
+}
+
+#if ENABLE(ASSERT)
+void DisplayItemList::assertDisplayItemClientsAreAlive() const
+{
+    for (auto& item : *this) {
+#ifdef NDEBUG
+        DCHECK(DisplayItemClient::isAlive(item.client())) << "Short-lived DisplayItemClient. See crbug.com/570030.";
+#else
+        DCHECK(DisplayItemClient::isAlive(item.client())) << "Short-lived DisplayItemClient: " << item.clientDebugString() << ". See crbug.com/570030.";
+#endif
+    }
+}
+#endif
+
 void DisplayItemList::appendVisualRect(const IntRect& visualRect)
 {
     size_t itemIndex = m_visualRects.size();
     const DisplayItem& item = (*this)[itemIndex];
 
     // For paired display items such as transforms, since we are not guaranteed containment, the
     // visual rect must comprise the union of the visual rects for all items within its block.
 
     if (item.isBegin()) {
         m_visualRects.append(visualRect);
@@ skipping 27 matching lines @@
     return Range<iterator>(begin() + paintChunk.beginIndex, begin() + paintChunk.endIndex);
 }
 
 DisplayItemList::Range<DisplayItemList::const_iterator>
 DisplayItemList::itemsInPaintChunk(const PaintChunk& paintChunk) const
 {
     return Range<const_iterator>(begin() + paintChunk.beginIndex, begin() + paintChunk.endIndex);
 }
 
 } // namespace blink