Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1812143004: Revert of Restore per-TypedArray-class length accessors as a perf workaround (Closed)

Created:
4 years, 9 months ago by Dan Ehrenberg
Modified:
4 years, 9 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Restore per-TypedArray-class length accessors as a perf workaround (patchset #2 id:20001 of https://codereview.chromium.org/1624383003/ ) Reason for revert: This patch actually seemed to cause a further GameBoy regression! Reverting it seems to address the regression. Original issue's description: > Restore per-TypedArray-class length accessors as a perf workaround > > This patch is a workaround to the performance regression caused by > implementing the ES2015 TypedArray prototype chain: Include a > per-TypedArray-subclass length getter so that the superclass getter does > not become polymorphic. The patch appears to fix a regression in the > Gameboy Octane benchmark. > > BUG=chromium:579905 > R=adamk > LOG=Y > > Committed: https://crrev.com/03ce7711e474a0ef74f723b30ae1527c89dec010 > Cr-Commit-Position: refs/heads/master@{#33501} R=adamk@chromium.org BUG=chromium:579905, chromium:593634 LOG=Y Committed: https://crrev.com/0d2e28cb240fa3e7b2855f3b29278dee8688377d Cr-Commit-Position: refs/heads/master@{#34906}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M src/js/typedarray.js View 2 chunks +0 lines, -11 lines 0 comments Download
M test/mjsunit/es6/typedarray-proto.js View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Dan Ehrenberg
Created Revert of Restore per-TypedArray-class length accessors as a perf workaround
4 years, 9 months ago (2016-03-18 18:03:47 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812143004/1
4 years, 9 months ago (2016-03-18 18:04:46 UTC) #4
adamk
lgtm
4 years, 9 months ago (2016-03-18 18:26:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812143004/1
4 years, 9 months ago (2016-03-18 18:27:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 18:29:08 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 18:29:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d2e28cb240fa3e7b2855f3b29278dee8688377d
Cr-Commit-Position: refs/heads/master@{#34906}

Powered by Google App Engine
This is Rietveld 408576698