Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1812103002: Fix fast intrinsics for getters and setters; previous strategy was too conservative. (Closed)

Created:
4 years, 9 months ago by srdjan
Modified:
4 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Florian Schneider
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix fast intrinsics for getters and setters; previous strategy was too conservative. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/3c0dc0ab1b624a0f96eecbff16fbbe75875d50d8

Patch Set 1 #

Patch Set 2 : setter cannnot be intrinsified if we are tracking concrete field (i.e., not kDynamic). #

Patch Set 3 : r #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/flow_graph_compiler.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
srdjan
4 years, 9 months ago (2016-03-17 22:26:05 UTC) #2
rmacnak
lgtm
4 years, 9 months ago (2016-03-18 00:06:59 UTC) #3
srdjan
4 years, 9 months ago (2016-03-18 16:38:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
3c0dc0ab1b624a0f96eecbff16fbbe75875d50d8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698