net/cert/cert_verify_proc_nss.cc - Issue 18121007: *WIP* Store NSS slots per profile. Move keygen to chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/cert_verify_proc_nss.cc

Issue 18121007: *WIP* Store NSS slots per profile. Move keygen to chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: cleanups, add test for chrome keygen class Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/cert_verify_proc_nss.cc

diff --git a/net/cert/cert_verify_proc_nss.cc b/net/cert/cert_verify_proc_nss.cc

index 0a0743c150d7a5487a6758d423093bf1f21008c2..117ea629b69bbf7da117a38d2cc9b402c9539a4b 100644

--- a/net/cert/cert_verify_proc_nss.cc

+++ b/net/cert/cert_verify_proc_nss.cc

@@ -451,6 +451,7 @@ SECStatus PKIXVerifyCert(CERTCertificate* cert_handle,

in_param.type = cert_pi_end;

cvin.push_back(in_param);

+ // XXX can't specify slots here

Ryan Sleevi 2013/10/09 19:18:00 Why would you need to? What's the thought?

mattm 2013/10/09 23:52:38 Mentioned in an earlier reply, but was just thinki

SECStatus rv = CERT_PKIXVerifyCert(cert_handle, certificateUsageSSLServer,

&cvin[0], cvout, NULL);

if (rv != SECSuccess) {