Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: content/browser/loader/resource_loader.cc

Issue 18121007: *WIP* Store NSS slots per profile. Move keygen to chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanups, add test for chrome keygen class Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_loader.cc
diff --git a/content/browser/loader/resource_loader.cc b/content/browser/loader/resource_loader.cc
index 5b0a9f4a284fe0997a4486f6c9ea7e6293fba2c8..6a08879049c7a92def8ca40ef980eb32b5a6f5d2 100644
--- a/content/browser/loader/resource_loader.cc
+++ b/content/browser/loader/resource_loader.cc
@@ -306,6 +306,17 @@ void ResourceLoader::OnCertificateRequested(
}
#if !defined(USE_OPENSSL)
+ // XXX
+ //ResourceRequestInfoImpl* info = GetRequestInfo();
+ //ResourceContext* context = info->context;
+ //XXX: needs to go through chrome:
+ //ProfileIOData* io_data = ProfileIOData::FromResourceContext(context);
+ //crypto::ScopedPK11Slot slot(io_data->GetFooNSSKeySlot())
+ //XX maybe:
+ //ClientCertStore should be a content interface, implemneted by chrome/, and
+ //takes resourceContext argument. Chrome impl can get proper slot and call
+ //into per-platform net implementation of clientcertstore, similar to keygen.
+ // XXX how would we get the chrome impl of ClientCertStore into this class?
client_cert_store_->GetClientCerts(*cert_info, &cert_info->client_certs);
if (cert_info->client_certs.empty()) {
// No need to query the user if there are no certs to choose from.

Powered by Google App Engine
This is Rietveld 408576698