Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Unified Diff: content/browser/renderer_host/render_message_filter.cc

Issue 18121007: *WIP* Store NSS slots per profile. Move keygen to chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_message_filter.cc
diff --git a/content/browser/renderer_host/render_message_filter.cc b/content/browser/renderer_host/render_message_filter.cc
index 394f916da9f66f9c82a6d1ed8d9b96336fcc0fdf..6e9fcccb8a37a08091e9cfe03b522a525441b0b6 100644
--- a/content/browser/renderer_host/render_message_filter.cc
+++ b/content/browser/renderer_host/render_message_filter.cc
@@ -53,7 +53,7 @@
#include "media/audio/audio_parameters.h"
#include "media/base/media_log_event.h"
#include "net/base/io_buffer.h"
-#include "net/base/keygen_handler.h"
+//XXX #include "net/base/keygen_handler.h"
#include "net/base/mime_util.h"
#include "net/base/request_priority.h"
#include "net/cookies/canonical_cookie.h"
@@ -925,6 +925,8 @@ void RenderMessageFilter::OnKeygen(uint32 key_size_index,
const std::string& challenge_string,
const GURL& url,
IPC::Message* reply_msg) {
+ LOG(INFO) << "render_process_id_:" << render_process_id_
+ << " routing_id:" << reply_msg->routing_id();
// Map displayed strings indicating level of keysecurity in the <keygen>
// menu to the key size in bits. (See SSLKeyGeneratorChromium.cpp in WebCore.)
int key_size_in_bits;
@@ -942,40 +944,18 @@ void RenderMessageFilter::OnKeygen(uint32 key_size_index,
return;
}
- VLOG(1) << "Dispatching keygen task to worker pool.";
- // Dispatch to worker pool, so we do not block the IO thread.
- if (!base::WorkerPool::PostTask(
- FROM_HERE,
- base::Bind(
- &RenderMessageFilter::OnKeygenOnWorkerThread, this,
- key_size_in_bits, challenge_string, url, reply_msg),
- true)) {
- NOTREACHED() << "Failed to dispatch keygen task to worker pool";
- ViewHostMsg_Keygen::WriteReplyParams(reply_msg, std::string());
- Send(reply_msg);
- return;
- }
+ GetContentClient()->browser()->Keygen(
+ resource_context_,
+ key_size_in_bits,
+ challenge_string,
+ url,
+ base::Bind(&RenderMessageFilter::OnKeygenComplete, this, reply_msg));
}
-void RenderMessageFilter::OnKeygenOnWorkerThread(
- int key_size_in_bits,
- const std::string& challenge_string,
- const GURL& url,
- IPC::Message* reply_msg) {
- DCHECK(reply_msg);
-
- // Generate a signed public key and challenge, then send it back.
- net::KeygenHandler keygen_handler(key_size_in_bits, challenge_string, url);
-
-#if defined(USE_NSS)
- // Attach a password delegate so we can authenticate.
- keygen_handler.set_crypto_module_password_delegate(
- GetContentClient()->browser()->GetCryptoPasswordDelegate(url));
-#endif // defined(USE_NSS)
-
- ViewHostMsg_Keygen::WriteReplyParams(
- reply_msg,
- keygen_handler.GenKeyAndSignChallenge());
+void RenderMessageFilter::OnKeygenComplete(
+ IPC::Message* reply_msg,
+ const std::string* result) {
+ ViewHostMsg_Keygen::WriteReplyParams(reply_msg, result ? *result : "");
Send(reply_msg);
}

Powered by Google App Engine
This is Rietveld 408576698