Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1812073002: Add missing histograms entry for GPU process startup time. (Closed)

Created:
4 years, 9 months ago by DaleCurtis
Modified:
4 years, 9 months ago
Reviewers:
jwd, piman
CC:
asvitkine+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing histograms entry for GPU process startup time. Added way back in http://crrev.com/131691, but never had an XML entry added so it would show up on the dashboard! This means the UMA was logged (I think), but is not visible on dashboards. Found while working on http://crrev.com/1805163002 BUG=none TEST=none Committed: https://crrev.com/4d29aa7b57b7297baabb45524ee205d4d35d4e35 Cr-Commit-Position: refs/heads/master@{#382104}

Patch Set 1 #

Patch Set 2 : Fix owner. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M tools/metrics/histograms/histograms.xml View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
DaleCurtis
+piman to vouch for who should be the owner of this UMA. I copied vangelis@ ...
4 years, 9 months ago (2016-03-17 20:56:16 UTC) #2
piman
vangelis doesn't work on Chromium any more... Put me instead?
4 years, 9 months ago (2016-03-17 23:11:43 UTC) #3
DaleCurtis
Done. Made you the owner of GPU.GPUProcessLaunchCause too since that was the only other one ...
4 years, 9 months ago (2016-03-17 23:20:45 UTC) #4
piman
lgtm
4 years, 9 months ago (2016-03-17 23:33:26 UTC) #5
DaleCurtis
Friendly ping jwd@.
4 years, 9 months ago (2016-03-18 16:31:12 UTC) #6
jwd
lgtm
4 years, 9 months ago (2016-03-18 20:29:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812073002/20001
4 years, 9 months ago (2016-03-18 20:30:00 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-18 21:58:21 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 22:00:13 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4d29aa7b57b7297baabb45524ee205d4d35d4e35
Cr-Commit-Position: refs/heads/master@{#382104}

Powered by Google App Engine
This is Rietveld 408576698