SkPDF: Add SkPDFCanvas to intercept some draw calls

SkPDF: Add SkPDFCanvas to intercept some draw calls

Motivation: this simplifies implementation at the device level.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1812063002

Committed: https://skia.googlesource.com/skia/+/66be626f7f3ddda243e51aa8f36398b26769a9b4

[hal.canary, 2016-03-17 20:49:23]

Description was changed from

==========
SkPDF: Add SkPDFCanvas to intercept some draw calls

Motivation: this simplifies implementation at the device level.
==========

to

==========
SkPDF: Add SkPDFCanvas to intercept some draw calls

Motivation: this simplifies implementation at the device level.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[hal.canary, 2016-03-17 20:50:21]

halcanary@google.com changed reviewers:
+ reed@google.com, tomhudson@google.com

[hal.canary, 2016-03-17 20:50:22]

ptal

[hal.canary, 2016-03-17 20:54:07]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-17 20:54:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812063002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812063002/1

[commit-bot: I haz the power, 2016-03-17 21:07:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 21:07:17]

Dry run: This issue passed the CQ dry run.

[tomhudson, 2016-03-21 14:43:21]

lgtm

Assuming there's nothing anywhere else that depends on Device as an entry point?

[reed1, 2016-03-21 14:58:19]

reed@google.com changed reviewers:
+ robertphillips@google.com

[reed1, 2016-03-21 14:58:20]

Interesting.

Why is this simpler? What is it about canvas today that makes it complicated for
PDF?

[hal.canary, 2016-03-21 16:49:08]

On 2016/03/21 14:58:20, reed1 wrote:
> Interesting.
> 
> Why is this simpler? What is it about canvas today that makes it complicated
for
> PDF?

It is tricky to perform a clip at the device level.  It is easy at the canvas
level.  drawImageRect is a clip and a transform.

[hal.canary, 2016-03-21 16:49:38]

On 2016/03/21 14:43:21, tomhudson wrote:
> lgtm
> 
> Assuming there's nothing anywhere else that depends on Device as an entry
point?

this actually produces more correct output.

[reed1, 2016-03-21 17:21:46]

https://codereview.chromium.org/1812063002/diff/1/src/pdf/SkPDFCanvas.cpp
File src/pdf/SkPDFCanvas.cpp (right):

https://codereview.chromium.org/1812063002/diff/1/src/pdf/SkPDFCanvas.cpp#new...
src/pdf/SkPDFCanvas.cpp:23: this->drawBitmapRect(bitmap, srcR, dstR, paint);
it might be clearer if we scope these explicitly to call the base-class version:

e.g.

this->INHERITED::drawBitmapRect(...)

[hal.canary, 2016-03-21 17:25:53]

On 2016/03/21 17:21:46, reed1 wrote:
> https://codereview.chromium.org/1812063002/diff/1/src/pdf/SkPDFCanvas.cpp
> File src/pdf/SkPDFCanvas.cpp (right):
> 
>
https://codereview.chromium.org/1812063002/diff/1/src/pdf/SkPDFCanvas.cpp#new...
> src/pdf/SkPDFCanvas.cpp:23: this->drawBitmapRect(bitmap, srcR, dstR, paint);
> it might be clearer if we scope these explicitly to call the base-class
version:
> 
> e.g.
> 
> this->INHERITED::drawBitmapRect(...)

drawBitmapRect is not virtual.

[hal.canary, 2016-03-21 19:44:53]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2016-03-21 19:44:53]

The patchset sent to the CQ was uploaded after l-g-t-m from tomhudson@google.com
Link to the patchset: https://codereview.chromium.org/1812063002/#ps20001
(title: "2016-03-21 (Monday) 15:44:28 EDT")

[commit-bot: I haz the power, 2016-03-21 19:44:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812063002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812063002/20001

[commit-bot: I haz the power, 2016-03-21 20:01:37]

Description was changed from

==========
SkPDF: Add SkPDFCanvas to intercept some draw calls

Motivation: this simplifies implementation at the device level.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkPDF: Add SkPDFCanvas to intercept some draw calls

Motivation: this simplifies implementation at the device level.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/66be626f7f3ddda243e51aa8f36398b26769a9b4
==========

[commit-bot: I haz the power, 2016-03-21 20:01:39]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/66be626f7f3ddda243e51aa8f36398b26769a9b4