Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: content/browser/gpu/gpu_ipc_browsertests.cc

Issue 1812033002: Restore earlyouts in SignalTests on Windows for IPC flavour of the tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: earlyouts: . Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/gpu/client/gpu_context_tests.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/gpu/gpu_ipc_browsertests.cc
diff --git a/content/browser/gpu/gpu_ipc_browsertests.cc b/content/browser/gpu/gpu_ipc_browsertests.cc
index 9a3262dd880108094d7864d81f15a55d5703f123..ff5fc8e3fdeec88bc22c578facf0828024a84475 100644
--- a/content/browser/gpu/gpu_ipc_browsertests.cc
+++ b/content/browser/gpu/gpu_ipc_browsertests.cc
@@ -30,6 +30,8 @@ const content::CauseForGpuLaunch kInitCause =
class ContextTestBase : public content::ContentBrowserTest {
public:
void SetUpOnMainThread() override {
+ // This may leave the provider_ null in some cases, so tests need to early
+ // out.
if (!content::BrowserGpuChannelHostFactory::CanUseForTesting())
return;
@@ -71,8 +73,8 @@ class ContextTestBase : public content::ContentBrowserTest {
}
protected:
- gpu::gles2::GLES2Interface* gl_;
- gpu::ContextSupport* context_support_;
+ gpu::gles2::GLES2Interface* gl_ = nullptr;
+ gpu::ContextSupport* context_support_ = nullptr;
private:
scoped_refptr<content::ContextProviderCommandBuffer> provider_;
« no previous file with comments | « no previous file | content/common/gpu/client/gpu_context_tests.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698