Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1812033002: Restore earlyouts in SignalTests on Windows for IPC flavour of the tests (Closed)

Created:
4 years, 9 months ago by danakj
Modified:
4 years, 9 months ago
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, dcheng, Ken Russell (switch to Gerrit), piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore earlyouts in SignalTests on Windows for IPC flavour of the tests These tests fail to set up correctly on Windows, so running the tests just crashes. Restore the early outs with an ifdef for windows so we document where the early out will happen, along with comments. R=kbr@chromium.org, piman@chromium.org BUG=595823, 584497 Committed: https://crrev.com/1bbe2d3a6aa7e138eb968dafd058efb8c440a84d Cr-Commit-Position: refs/heads/master@{#381802}

Patch Set 1 #

Patch Set 2 : earlyouts: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -2 lines) Patch
M content/browser/gpu/gpu_ipc_browsertests.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/common/gpu/client/gpu_context_tests.h View 6 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
danakj
4 years, 9 months ago (2016-03-17 20:07:46 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812033002/20001
4 years, 9 months ago (2016-03-17 20:27:37 UTC) #3
danakj
+sievers
4 years, 9 months ago (2016-03-17 21:14:00 UTC) #5
no sievers
lgtm
4 years, 9 months ago (2016-03-17 21:16:25 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-17 21:22:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812033002/20001
4 years, 9 months ago (2016-03-17 21:33:44 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 21:40:27 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 21:42:00 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1bbe2d3a6aa7e138eb968dafd058efb8c440a84d
Cr-Commit-Position: refs/heads/master@{#381802}

Powered by Google App Engine
This is Rietveld 408576698