Get rid of mountPath dependency in Files app.

chrome/browser/resources/file_manager/background/js/volume_manager.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * Represents each volume, such as "drive", "download directory", each "USB
  * flush storage", or "mounted zip archive" etc.
  *
@@ skipping 526 matching lines @@
   }.bind(this));
 };
 
 /**
  * Event handler called when some volume was mounted or unmounted.
  * @param {MountCompletedEvent} event Received event.
  * @private
  */
 VolumeManager.prototype.onMountCompleted_ = function(event) {
   this.mountQueue_.run(function(callback) {
-    if (event.eventType === 'mount') {
-      var requestKey = this.makeRequestKey_(
-          'mount',
-          event.volumeMetadata.sourcePath);
+    switch (event.eventType) {
+      case 'mount':
+        var requestKey = this.makeRequestKey_(
+            'mount',
+            event.volumeMetadata.sourcePath);
 
-      // TODO(mtomasz): Migrate to volumeId once possible.
-      if (event.volumeMetadata.mountPath) {
         var error = event.status === 'success' ? '' : event.status;
-        volumeManagerUtil.createVolumeInfo(
-            event.volumeMetadata,
-            function(volumeInfo) {
-              this.volumeInfoList.add(volumeInfo);
-              this.finishRequest_(requestKey, event.status, volumeInfo);
-              if (volumeInfo.volumeType === util.VolumeType.DRIVE) {
-                // Update the network connection status, because until the
-                // drive is initialized, the status is set to not ready.
-                // TODO(hidehiko): The connection status should be migrated into
-                // VolumeMetadata.
-                this.onDriveConnectionStatusChanged_();
-              }
-              callback();
-            }.bind(this));
-      } else {
-        console.warn('No mount path.');
-        this.finishRequest_(requestKey, event.status);
+        if (!error || event.status === 'error_unknown_filesystem') {
+          volumeManagerUtil.createVolumeInfo(
+              event.volumeMetadata,
+              function(volumeInfo) {
+                this.volumeInfoList.add(volumeInfo);
+                this.finishRequest_(requestKey, event.status, volumeInfo);
+
+                if (volumeInfo.volumeType === util.VolumeType.DRIVE) {
+                  // Update the network connection status, because until the
+                  // drive is initialized, the status is set to not ready.
+                  // TODO(hidehiko): The connection status should be migrated into

[hirono, 2014/03/03 01:58:23]

nit: Over 80 characters?

[mtomasz, 2014/03/03 02:18:54]

Done.

+                  // VolumeMetadata.
+                  this.onDriveConnectionStatusChanged_();
+                }
+                callback();
+              }.bind(this));
+        } else {
+          console.warn('Failed to mount a volume: ' + event.status);
+          this.finishRequest_(requestKey, event.status);
+          callback();
+        }
+        break;
+      case 'unmount':

[hirono, 2014/03/03 01:58:23]

nit: Please insert a line before #576.

[mtomasz, 2014/03/03 02:18:54]

Done.

+        var volumeId = event.volumeMetadata.volumeId;
+        var status = event.status;
+        if (status === util.VolumeError.PATH_UNMOUNTED) {
+          console.warn('Volume already unmounted: ', volumeId);
+          status = 'success';
+        }
+        var requestKey = this.makeRequestKey_('unmount', volumeId);
+        var requested = requestKey in this.requests_;
+        var volumeInfoIndex =
+            this.volumeInfoList.findIndex(volumeId);
+        var volumeInfo = volumeInfoIndex !== -1 ?
+            this.volumeInfoList.item(volumeInfoIndex) : null;
+        if (event.status === 'success' && !requested && volumeInfo) {
+          console.warn('Mounted volume without a request: ' + volumeId);
+          var e = new Event('externally-unmounted');
+          e.volumeInfo = volumeInfo;
+          this.dispatchEvent(e);
+        }
+
+        this.finishRequest_(requestKey, status);
+        if (event.status === 'success')
+          this.volumeInfoList.remove(event.volumeMetadata.volumeId);
         callback();
-      }
-    } else if (event.eventType === 'unmount') {
-      var volumeId = event.volumeMetadata.volumeId;
-      var status = event.status;
-      if (status === util.VolumeError.PATH_UNMOUNTED) {
-        console.warn('Volume already unmounted: ', volumeId);
-        status = 'success';
-      }
-      var requestKey = this.makeRequestKey_('unmount', volumeId);
-      var requested = requestKey in this.requests_;
-      var volumeInfoIndex =
-          this.volumeInfoList.findIndex(volumeId);
-      var volumeInfo = volumeInfoIndex !== -1 ?
-          this.volumeInfoList.item(volumeInfoIndex) : null;
-      if (event.status === 'success' && !requested && volumeInfo) {
-        console.warn('Mounted volume without a request: ', volumeId);
-        var e = new Event('externally-unmounted');
-        e.volumeInfo = volumeInfo;
-        this.dispatchEvent(e);
-      }
-      this.finishRequest_(requestKey, status);
-
-      if (event.status === 'success')
-        this.volumeInfoList.remove(event.volumeMetadata.volumeId);
-      callback();
+        break;
     }
   }.bind(this));
 };
 
 /**
  * Creates string to match mount events with requests.
  * @param {string} requestType 'mount' | 'unmount'. TODO(hidehiko): Replace by
  *     enum.
  * @param {string} argument Argument describing the request, eg. source file
  *     path of the archive to be mounted, or a volumeId for unmounting.
@@ skipping 91 matching lines @@
                entry.fullPath.indexOf('/other/') === 0) {
       rootType = RootType.DRIVE_OTHER;
       isReadOnly = true;
       isRootEntry = entry.fullPath === '/other';
     } else {
       // Accessing Drive files outside of /drive/root and /drive/other is not
       // allowed, but can happen. Therefore returning null.
       return null;
     }
   } else {
-    // Otherwise, root path is same with a mount path of the volume.
     switch (volumeInfo.volumeType) {
       case util.VolumeType.DOWNLOADS:
         rootType = RootType.DOWNLOADS;
         break;
       case util.VolumeType.REMOVABLE:
         rootType = RootType.REMOVABLE;
         break;
       case util.VolumeType.ARCHIVE:
         rootType = RootType.ARCHIVE;
         break;
@@ skipping 146 matching lines @@
       this.isDriveBased;
 
   /**
    * Whether the entry is read only or not.
    * @type {boolean}
    */
   this.isReadOnly = isReadOnly;
 
   Object.freeze(this);
 }