Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 181203002: Get rid of mountPath dependency in Files app. (Closed)

Created:
6 years, 10 months ago by mtomasz
Modified:
6 years, 9 months ago
Reviewers:
benwells, hirono, kinaba
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Get rid of mountPath dependency in Files app. This patch simplifies the code and removed the dependency on mount path, which was redundant after migrating to volume ids and file systems per volume. TEST=Tested manually, mounted and unmounted a archive and a usb device. BUG=341263 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255348

Patch Set 1 #

Patch Set 2 : Fixed. #

Patch Set 3 : Cleaned up. #

Patch Set 4 : Rebased + cleaned up. #

Total comments: 4

Patch Set 5 : Addressed comments. #

Patch Set 6 : Fixed tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -76 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/event_router.cc View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_util.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/resources/file_manager/background/js/volume_manager.js View 1 2 3 4 2 chunks +52 lines, -49 lines 0 comments Download
M chrome/browser/resources/image_loader/image_loader.js View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/extensions/api/file_browser_private.idl View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/mount_test/test.js View 1 2 3 4 5 6 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
mtomasz
@kinaba: PTAL. This CL depends on https://codereview.chromium.org/179553008/. Thanks.
6 years, 10 months ago (2014-02-26 08:15:05 UTC) #1
kinaba
lgtm
6 years, 9 months ago (2014-02-27 01:07:53 UTC) #2
mtomasz
@hirono: PTAL at JS. Thanks.
6 years, 9 months ago (2014-03-03 01:39:15 UTC) #3
hirono
lgtm with two nits. https://codereview.chromium.org/181203002/diff/60001/chrome/browser/resources/file_manager/background/js/volume_manager.js File chrome/browser/resources/file_manager/background/js/volume_manager.js (right): https://codereview.chromium.org/181203002/diff/60001/chrome/browser/resources/file_manager/background/js/volume_manager.js#newcode564 chrome/browser/resources/file_manager/background/js/volume_manager.js:564: // TODO(hidehiko): The connection status ...
6 years, 9 months ago (2014-03-03 01:58:23 UTC) #4
mtomasz
https://codereview.chromium.org/181203002/diff/60001/chrome/browser/resources/file_manager/background/js/volume_manager.js File chrome/browser/resources/file_manager/background/js/volume_manager.js (right): https://codereview.chromium.org/181203002/diff/60001/chrome/browser/resources/file_manager/background/js/volume_manager.js#newcode564 chrome/browser/resources/file_manager/background/js/volume_manager.js:564: // TODO(hidehiko): The connection status should be migrated into ...
6 years, 9 months ago (2014-03-03 02:18:53 UTC) #5
mtomasz
@benwells: PTAL at file_browser_private.idl. Thanks.
6 years, 9 months ago (2014-03-03 02:19:20 UTC) #6
benwells
lgtm
6 years, 9 months ago (2014-03-03 02:25:49 UTC) #7
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 9 months ago (2014-03-03 02:26:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/181203002/80001
6 years, 9 months ago (2014-03-03 02:26:36 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 05:38:28 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=206896
6 years, 9 months ago (2014-03-03 05:38:28 UTC) #11
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 9 months ago (2014-03-06 07:55:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/181203002/100001
6 years, 9 months ago (2014-03-06 07:56:13 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 08:06:46 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-06 08:06:47 UTC) #15
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 9 months ago (2014-03-06 08:06:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/181203002/100001
6 years, 9 months ago (2014-03-06 08:07:09 UTC) #17
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 14:31:29 UTC) #18
Message was sent while issue was closed. 
Change committed as 255348

Powered by Google App Engine
This is Rietveld 408576698