Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1812023002: Switch SkSpecialImage & SkSpecialSurface classes over to smart pointers (Closed)

Created:
4 years, 9 months ago by robertphillips
Modified:
4 years, 9 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update to ToT #

Patch Set 3 : Fix tests #

Patch Set 4 : clean up #

Patch Set 5 : more clean up #

Patch Set 6 : update to ToT (again) #

Total comments: 2

Patch Set 7 : Address code review comments #

Patch Set 8 : Fix indent #

Patch Set 9 : update to ToT (again) #

Patch Set 10 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+283 lines, -268 lines) Patch
M gm/offsetimagefilter.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M gm/tileimagefilter.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkImageSource.h View 1 2 3 4 5 6 7 2 chunks +7 lines, -7 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M src/core/SkDevice.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 2 3 4 5 6 chunks +14 lines, -14 lines 0 comments Download
M src/core/SkSpecialImage.h View 1 2 3 4 5 6 2 chunks +22 lines, -19 lines 0 comments Download
M src/core/SkSpecialImage.cpp View 1 2 3 4 5 6 7 8 9 12 chunks +75 lines, -67 lines 0 comments Download
M src/core/SkSpecialSurface.h View 2 chunks +13 lines, -12 lines 0 comments Download
M src/core/SkSpecialSurface.cpp View 1 2 3 4 8 chunks +34 lines, -34 lines 0 comments Download
M src/effects/SkImageSource.cpp View 1 2 3 4 5 6 5 chunks +12 lines, -11 lines 0 comments Download
M src/effects/SkMergeImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkOffsetImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkPaintImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrLayerHoister.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/ImageFilterCacheTest.cpp View 1 2 13 chunks +24 lines, -28 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 2 3 4 5 12 chunks +32 lines, -31 lines 0 comments Download
M tests/SpecialImageTest.cpp View 1 9 chunks +23 lines, -21 lines 0 comments Download
M tests/SpecialSurfaceTest.cpp View 6 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
robertphillips
4 years, 9 months ago (2016-03-17 19:36:12 UTC) #4
reed1
factories that take a refable dude that they are SURE they're gonna ref, should pass ...
4 years, 9 months ago (2016-03-17 19:49:24 UTC) #5
robertphillips
PTAL https://codereview.chromium.org/1812023002/diff/100001/include/effects/SkImageSource.h File include/effects/SkImageSource.h (right): https://codereview.chromium.org/1812023002/diff/100001/include/effects/SkImageSource.h#newcode41 include/effects/SkImageSource.h:41: sk_sp<const SkImage> fImage; On 2016/03/17 19:49:24, reed1 wrote: ...
4 years, 9 months ago (2016-03-17 20:14:16 UTC) #6
reed1
lgtm
4 years, 9 months ago (2016-03-17 20:48:17 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812023002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812023002/160001
4 years, 9 months ago (2016-03-17 21:04:46 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/5443)
4 years, 9 months ago (2016-03-17 21:05:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812023002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812023002/180001
4 years, 9 months ago (2016-03-17 21:17:16 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 21:31:43 UTC) #16
Message was sent while issue was closed. 
Committed patchset #10 (id:180001) as
https://skia.googlesource.com/skia/+/37bd7c3aca66697fff2db79c21771a0b3cbe3b4c

Powered by Google App Engine
This is Rietveld 408576698