ash/shell/shell_delegate_impl.h - Issue 1812013003: Pass shelf instances, not root windows, for ash context menus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shell/shell_delegate_impl.h

Issue 1812013003: Pass shelf instances, not root windows, for ash context menus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call OnShelfAlignmentChanged after LayoutShelf. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/shell/shell_delegate_impl.h

diff --git a/ash/shell/shell_delegate_impl.h b/ash/shell/shell_delegate_impl.h

index c53c702f266f8fb5d6774bb5d84031818f0bbba9..7a5684b519682aaa03662daa7a01644fdb928699 100644

--- a/ash/shell/shell_delegate_impl.h

+++ b/ash/shell/shell_delegate_impl.h

@@ -48,7 +48,7 @@ class ShellDelegateImpl : public ash::ShellDelegate {

ash::AccessibilityDelegate* CreateAccessibilityDelegate() override;

ash::NewWindowDelegate* CreateNewWindowDelegate() override;

ash::MediaDelegate* CreateMediaDelegate() override;

- ui::MenuModel* CreateContextMenu(aura::Window* root_window,

+ ui::MenuModel* CreateContextMenu(ash::Shelf* shelf,

const ash::ShelfItem* item) override;

GPUSupport* CreateGPUSupport() override;

base::string16 GetProductName() const override;

« no previous file with comments | « ash/shell/context_menu.cc ('k') | ash/shell/shell_delegate_impl.cc » ('j') | no next file with comments »