Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4886)

Unified Diff: chrome/browser/ui/webui/options/import_data_handler.cc

Issue 18120005: Remove Google Toolbar importer (aka google.com/bookmarks importer). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove google toolbar strings Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/import_data_handler.cc
diff --git a/chrome/browser/ui/webui/options/import_data_handler.cc b/chrome/browser/ui/webui/options/import_data_handler.cc
index 5c5c339285f0b9bb04cf1c13e9ac5ba0eb04fec9..a425f836c0c6e0b21ebd7f388ec4a050077eebf1 100644
--- a/chrome/browser/ui/webui/options/import_data_handler.cc
+++ b/chrome/browser/ui/webui/options/import_data_handler.cc
@@ -18,7 +18,6 @@
#include "base/values.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/importer/external_process_importer_host.h"
-#include "chrome/browser/importer/importer_host.h"
#include "chrome/browser/importer/importer_list.h"
#include "chrome/browser/importer/importer_type.h"
#include "chrome/browser/profiles/profile.h"
@@ -65,8 +64,7 @@ void ImportDataHandler::GetLocalizedValues(DictionaryValue* localized_strings) {
}
void ImportDataHandler::InitializeHandler() {
- Profile* profile = Profile::FromWebUI(web_ui());
- importer_list_ = new ImporterList(profile->GetRequestContext());
+ importer_list_ = new ImporterList();
importer_list_->DetectSourceProfiles(
g_browser_process->GetApplicationLocale(), this);
}
@@ -111,16 +109,8 @@ void ImportDataHandler::ImportData(const ListValue* args) {
state);
import_did_succeed_ = false;
- // The Google Toolbar importer doesn't work for the out-of-process import.
- // This is the only entry point for this importer (it is never used on first
- // run). See discussion on http://crbug.com/219419 for details.
- if (source_profile.importer_type == importer::TYPE_GOOGLE_TOOLBAR5)
- importer_host_ = new ImporterHost;
- else
- importer_host_ = new ExternalProcessImporterHost;
+ importer_host_ = new ExternalProcessImporterHost;
James Hawkins 2013/06/28 03:08:15 nit: Host();
gab 2013/06/28 04:23:16 What do you mean? You want: importer_host_ = new E
James Hawkins 2013/06/28 15:23:59 Regardless of the rule, the code is currently inte
gab 2013/06/28 15:40:28 Done.
importer_host_->SetObserver(this);
- importer_host_->set_browser(
- chrome::FindBrowserWithWebContents(web_ui()->GetWebContents()));
Profile* profile = Profile::FromWebUI(web_ui());
importer_host_->StartImportSettings(source_profile, profile,
import_services,

Powered by Google App Engine
This is Rietveld 408576698