Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1556)

Issue 1811973006: [compiler] Move feedback vector allocation to pipeline. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Move feedback vector allocation to pipeline. This moves the call-sites that ensure we have a feedback vector present before kicking off a compiler into the actual compilation pipeline. The backends no longer need to worry about the feedback vector. R=mvstanton@chromium.org Committed: https://crrev.com/62d2aa45e493581af81e6278499a6be202edfbf3 Cr-Commit-Position: refs/heads/master@{#34900}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M src/compiler.cc View 3 chunks +3 lines, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-18 14:23:15 UTC) #1
mvstanton
Totally cool! LGTM, as long as the platform ports in full-codegen are the same as ...
4 years, 9 months ago (2016-03-18 14:52:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811973006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811973006/1
4 years, 9 months ago (2016-03-18 16:31:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 16:33:36 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 16:33:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62d2aa45e493581af81e6278499a6be202edfbf3
Cr-Commit-Position: refs/heads/master@{#34900}

Powered by Google App Engine
This is Rietveld 408576698