Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1811973005: Revert of Add SkSpecialImage::makeTextureImage entry point & update filterInput (Closed)

Created:
4 years, 9 months ago by bungeman-skia
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add SkSpecialImage::makeTextureImage entry point & update filterInput (patchset #3 id:40001 of https://codereview.chromium.org/1813813002/ ) Reason for revert: Suspected cause of layout test css3/filters/effect-reference-tile-hw.htmlto crash. https://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/83847/steps/webkit_tests%20%28with%20patch%29/logs/stdio It could also be the previous change (but it appears this one depends on that one). Original issue's description: > Add SkSpecialImage::makeTextureImage entry point > > This is calved off of: https://codereview.chromium.org/1785643003 (Switch SkBlurImageFilter over to new onFilterImage interface) > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1813813002 > > Committed: https://skia.googlesource.com/skia/+/05849018c85403a34b88819db1c4bcf713b70a2b TBR=bsalomon@google.com,senorblanco@google.com,senorblanco@chromium.org,robertphillips@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/92701ab7836124e8a57eacab17b26c567ad20dd7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -139 lines) Patch
M src/core/SkImageFilter.cpp View 1 chunk +1 line, -12 lines 0 comments Download
M src/core/SkSpecialImage.h View 2 chunks +0 lines, -11 lines 0 comments Download
M src/core/SkSpecialImage.cpp View 2 chunks +1 line, -39 lines 0 comments Download
M tests/SpecialImageTest.cpp View 2 chunks +1 line, -77 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
bungeman-skia
Created Revert of Add SkSpecialImage::makeTextureImage entry point & update filterInput
4 years, 9 months ago (2016-03-18 12:35:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811973005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811973005/1
4 years, 9 months ago (2016-03-18 12:36:13 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 12:36:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/92701ab7836124e8a57eacab17b26c567ad20dd7

Powered by Google App Engine
This is Rietveld 408576698