Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1597)

Unified Diff: third_party/WebKit/LayoutTests/transforms/transform-parsing.html

Issue 1811953002: Make parsing of <transform> more strict (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: V2 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/transforms/transform-parsing.html
diff --git a/third_party/WebKit/LayoutTests/transforms/transform-parsing.html b/third_party/WebKit/LayoutTests/transforms/transform-parsing.html
index ba171a29cb2221e39ec237def591ae1d037754c5..225d042415358066a294deff2c7c910e357fbe01 100644
--- a/third_party/WebKit/LayoutTests/transforms/transform-parsing.html
+++ b/third_party/WebKit/LayoutTests/transforms/transform-parsing.html
@@ -32,6 +32,7 @@ expect('translate(20%, 10%)').parsesAs('translate(20%, 10%)').isComputedTo('matr
expect('translate()').isInvalid();
expect('translate(1)').isInvalid();
expect('translate(1, 2)').isInvalid();
+expect('translate(1px,)').isInvalid();
expect('translate(1px, 2px, 3px)').isInvalid();
// translateX()
@@ -54,6 +55,7 @@ expect('translateY(1px, 2px)').isInvalid();
expect('scale(1)').parsesAs('scale(1)');
expect('scale(2, 3)').parsesAs('scale(2, 3)').isComputedTo('matrix(2, 0, 0, 3, 0, 0)');
expect('scale()').isInvalid();
+expect('scale(1,)').isInvalid();
expect('scale(1, 2, 3)').isInvalid();
expect('scale(1px, 2px)').isInvalid();
expect('scale(20%, 50%)').isInvalid();
@@ -92,6 +94,7 @@ expect('skew(0, 0)').parsesAs('skew(0deg, 0deg)');
expect('skew(1)').isInvalid();
expect('skew(2%)').isInvalid();
expect('skew()').isInvalid();
+expect('skew(45deg,)').isInvalid();
expect('skew(1deg, 2deg, 3deg)').isInvalid();
// skewX()
@@ -162,6 +165,7 @@ expect('rotate3d(1, 2, 3, 4deg)').parsesAs('rotate3d(1, 2, 3, 4deg)');
expect('rotate3d()').isInvalid();
expect('rotate3d(1, 2, 3)').isInvalid();
expect('rotate3d(1, 2, 3, 4deg, 0)').isInvalid();
+expect('rotate3d(1, 2, 3, )').isInvalid();
// rotateX()
expect('rotateX(0)').parsesAs('rotateX(0deg)');

Powered by Google App Engine
This is Rietveld 408576698