[serializer] ensure that immortal immovable roots are correctly deserialized.

src/snapshot/startup-serializer.h

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_SNAPSHOT_STARTUP_SERIALIZER_H_
 #define V8_SNAPSHOT_STARTUP_SERIALIZER_H_
 
+#include <bitset>
 #include "src/snapshot/serializer.h"
 
 namespace v8 {
 namespace internal {
 
 class StartupSerializer : public Serializer {
  public:
   enum FunctionCodeHandling { CLEAR_FUNCTION_CODE, KEEP_FUNCTION_CODE };
 
   StartupSerializer(
       Isolate* isolate, SnapshotByteSink* sink,
       FunctionCodeHandling function_code_handling = CLEAR_FUNCTION_CODE);
   ~StartupSerializer() override;
 
   // Serialize the current state of the heap.  The order is:
-  // 1) Strong references.
-  // 2) Partial snapshot cache.
-  // 3) Weak references (e.g. the string table).
+  // 1) Immortal immovable roots
+  // 2) Remaining strong references.
+  // 3) Partial snapshot cache.
+  // 4) Weak references (e.g. the string table).
   void SerializeStrongReferences();
   void SerializeWeakReferencesAndDeferred();
 
  private:
   // The StartupSerializer has to serialize the root array, which is slightly
   // different.
   void VisitPointers(Object** start, Object** end) override;
   void SerializeObject(HeapObject* o, HowToCode how_to_code,
                        WhereToPoint where_to_point, int skip) override;
   void Synchronize(VisitorSynchronization::SyncTag tag) override;
 
-  intptr_t root_index_wave_front_;
+  // Some roots should not be serialized, because their actual value depends on
+  // absolute addresses and they are reset after deserialization, anyway.
+  // In the first pass over the root list, we only serialize immortal immovable
+  // roots. In the second pass, we serialize the rest.
+  bool RootShouldBeSkipped(int root_index);
+
+  FunctionCodeHandling function_code_handling_;
   bool serializing_builtins_;
-  FunctionCodeHandling function_code_handling_;
+  bool serializing_immortal_immovables_roots_;
+  std::bitset<Heap::kStrongRootListLength> root_has_been_serialized_;
   DISALLOW_COPY_AND_ASSIGN(StartupSerializer);
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_SNAPSHOT_STARTUP_SERIALIZER_H_