Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: content/browser/plugin_service_impl.cc

Issue 18119009: Make utility process run in-process when running in single-process mode. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: add comment Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/plugin_service_impl.cc
===================================================================
--- content/browser/plugin_service_impl.cc (revision 209067)
+++ content/browser/plugin_service_impl.cc (working copy)
@@ -66,6 +66,13 @@
#else
// If on POSIX, we don't want to load the list of NPAPI plugins in-process as
// that causes instability.
+
+ // Can't load the plugins on the utility thread when in single process mode
+ // since that requires using WebKit and GTK and they can only be used on the
+ // main thread.
+ if (RenderProcessHost::run_renderer_in_process())
+ return true;
+
return !webkit::npapi::NPAPIPluginsSupported();
#endif
}

Powered by Google App Engine
This is Rietveld 408576698