Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 18119009: Make utility process run in-process when running in single-process mode. (Closed)

Created:
7 years, 5 months ago by jam
Modified:
7 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Make utility process run in-process when running in single-process mode. Remove the unit test/single process code path for SandboxedUnpacker as a first step. BUG=19192 R=asargent@chromium.org, scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210620

Patch Set 1 #

Patch Set 2 : add extensions unpacker code #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : try to fix clang #

Patch Set 8 : add more waits #

Patch Set 9 : fix extension tests that don't derive from ExtensionServiceTest to also work in-process #

Patch Set 10 : ensure utility thread shuts down #

Patch Set 11 : fix silly error that was triggering in asan builds #

Patch Set 12 : add comment #

Total comments: 1

Patch Set 13 : debugging #

Patch Set 14 : only run one utility thread at a time #

Patch Set 15 : fix race condition that was exposed in interactive tests. #

Patch Set 16 : test #

Patch Set 17 : simplify UtilityMainThread and resurrct TraceLog at beginning of test #

Patch Set 18 : sync after TraceEvent fix #

Patch Set 19 : undo unnecessary changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+376 lines, -178 lines) Patch
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 25 chunks +116 lines, -41 lines 0 comments Download
M chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +22 lines, -41 lines 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/startup_helper.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 4 chunks +6 lines, -1 line 0 comments Download
M chrome/utility/chrome_content_utility_client.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -1 line 0 comments Download
M content/browser/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +33 lines, -31 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/utility_process_host_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/utility_process_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 4 chunks +107 lines, -45 lines 0 comments Download
M content/content.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_client.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/content_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +10 lines, -0 lines 0 comments Download
M content/utility/utility_thread_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +7 lines, -0 lines 0 comments Download
M content/utility/utility_thread_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 4 chunks +38 lines, -8 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jam
7 years, 5 months ago (2013-07-01 18:26:20 UTC) #1
scottmg
lgtm https://codereview.chromium.org/18119009/diff/154001/content/utility/utility_thread_impl.h File content/utility/utility_thread_impl.h (right): https://codereview.chromium.org/18119009/diff/154001/content/utility/utility_thread_impl.h#newcode59 content/utility/utility_thread_impl.h:59: bool initialize_webkit_; might be clearer to call this ...
7 years, 5 months ago (2013-07-01 19:37:20 UTC) #2
jam
Scott: I've updated the change so that only one utility thread runs a time, to ...
7 years, 5 months ago (2013-07-02 22:45:52 UTC) #3
scottmg
lgtm2
7 years, 5 months ago (2013-07-02 22:54:20 UTC) #4
jam
oops i forgot to update the variable name to single_process_, did that locally now
7 years, 5 months ago (2013-07-02 23:17:34 UTC) #5
asargent_no_longer_on_chrome
7 years, 5 months ago (2013-07-09 21:04:28 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698