Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18119002: Use a direct include of time headers in base/, part 2. (Closed)

Created:
7 years, 5 months ago by Avi (use Gerrit)
Modified:
7 years, 5 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Use a direct include of time headers in base/, part 2. BUG=254986 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209144

Patch Set 1 #

Patch Set 2 : win fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -48 lines) Patch
M base/pending_task.h View 1 chunk +1 line, -1 line 0 comments Download
M base/perftimer.h View 1 chunk +1 line, -1 line 0 comments Download
M base/platform_file.h View 1 chunk +1 line, -1 line 0 comments Download
M base/platform_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/power_monitor/power_monitor.h View 1 chunk +1 line, -1 line 0 comments Download
M base/power_monitor/power_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/process_metrics.h View 1 chunk +1 line, -1 line 0 comments Download
M base/process_info_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process_info_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process_util.h View 1 chunk +1 line, -1 line 0 comments Download
M base/profiler/tracked_time.h View 1 chunk +1 line, -1 line 0 comments Download
M base/profiler/tracked_time.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/profiler/tracked_time_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/synchronization/cancellation_flag_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/synchronization/condition_variable_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/synchronization/condition_variable_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/synchronization/condition_variable_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/synchronization/spin_wait.h View 1 chunk +1 line, -1 line 0 comments Download
M base/synchronization/waitable_event_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/synchronization/waitable_event_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sys_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/system_monitor/system_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/task_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/mock_time_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/sequenced_task_runner_test_template.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/simple_test_clock.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/simple_test_tick_clock.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_launcher.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_launcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/test/test_pending_task.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_timeouts.h View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/platform_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/sequenced_worker_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/sequenced_worker_pool_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/threading/watchdog.h View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/watchdog_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/worker_pool_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/timer/timer.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/timer/timer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/tracked_objects_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/tracking_info.h View 1 chunk +1 line, -1 line 0 comments Download
M base/value_conversions.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/vlog_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/sampling_profiler.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/18119002/1
7 years, 5 months ago (2013-06-27 18:20:24 UTC) #1
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, chrome_frame_net_tests, ...
7 years, 5 months ago (2013-06-27 18:57:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/18119002/1
7 years, 5 months ago (2013-06-27 19:01:43 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-06-27 19:05:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/18119002/1
7 years, 5 months ago (2013-06-27 21:09:20 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-06-27 21:25:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/18119002/49
7 years, 5 months ago (2013-06-27 21:25:53 UTC) #7
Avi (use Gerrit)
7 years, 5 months ago (2013-06-28 15:14:27 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 manually as r209144 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698