Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 1811893002: Fix up dependency chain around net_features.h (Closed)

Created:
4 years, 9 months ago by blundell
Modified:
4 years, 9 months ago
CC:
chromium-reviews, tim+watch_chromium.org, cbentzel+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix up dependency chain around net_features.h //net exposes the generated net_features.h header as part of its public API (e.g., via http_network_session.h). That means that the GYP build of //net needs to export dependent settings on net_features. Similarly, //sync exposes //net headers that transitively include net_features.h via *its* public API (e.g., via http_bridge.h). This means that //sync needs to export dependent settings on //net. The GN build already gets this mostly right, so fewer fixes are needed there. BUG=594970 Committed: https://crrev.com/135b2ed3347a44635ae459396b4f7ab5c49849d9 Cr-Commit-Position: refs/heads/master@{#381910}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M net/net_common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M sync/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M sync/sync.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
droger
Is this BUG=594970?
4 years, 9 months ago (2016-03-17 09:05:31 UTC) #2
droger
lgtm
4 years, 9 months ago (2016-03-17 09:09:16 UTC) #4
blundell
rsleevi: please review //net zea: please review //sync An iOS dev uncovered this issue using ...
4 years, 9 months ago (2016-03-17 09:09:48 UTC) #6
Ryan Sleevi
lgtm
4 years, 9 months ago (2016-03-17 16:11:42 UTC) #7
Nicolas Zea
lgtm
4 years, 9 months ago (2016-03-17 23:04:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811893002/1
4 years, 9 months ago (2016-03-18 08:10:59 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 08:15:36 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 08:17:06 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/135b2ed3347a44635ae459396b4f7ab5c49849d9
Cr-Commit-Position: refs/heads/master@{#381910}

Powered by Google App Engine
This is Rietveld 408576698