Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1811883002: Remove unused WTFLogChannels. (Closed)

Created:
4 years, 9 months ago by tkent
Modified:
4 years, 9 months ago
Reviewers:
Yuta Kitamura
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused WTFLogChannels. Remove the following channels: - BackForward - Editing - Events - Frames - FTP - History - IconDatabase - Loading - PlatformLeaks - PopupBlocking - Progress - SpellingAndGrammar - LiveConnect - Threading - Compositing - Gamepad - ScriptedAnimationController They are unused. Committed: https://crrev.com/24eb1ea44b83c09bc3d6435073d692009b2fc6fb Cr-Commit-Position: refs/heads/master@{#381674}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -111 lines) Patch
M third_party/WebKit/Source/platform/Logging.h View 1 chunk +7 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/platform/Logging.cpp View 2 chunks +7 lines, -86 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
tkent
yutak@, would you review this please?
4 years, 9 months ago (2016-03-17 08:02:49 UTC) #3
Yuta Kitamura
LGTM, nice cleanup!
4 years, 9 months ago (2016-03-17 08:50:14 UTC) #4
Yuta Kitamura
LGTM, nice cleanup!
4 years, 9 months ago (2016-03-17 08:50:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811883002/1
4 years, 9 months ago (2016-03-17 08:54:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 09:04:34 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 09:12:38 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24eb1ea44b83c09bc3d6435073d692009b2fc6fb
Cr-Commit-Position: refs/heads/master@{#381674}

Powered by Google App Engine
This is Rietveld 408576698