Mojo C++ bindigns: fix generated namespace when variant is specified.

mojo/public/tools/bindings/generators/mojom_cpp_generator.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generates C++ source files from a mojom.Module."""
 
 import mojom.generate.generator as generator
 import mojom.generate.module as mojom
 import mojom.generate.pack as pack
 from mojom.generate.template_expander import UseJinja
@@ skipping 28 matching lines @@
   mojom.UINT16:       "U",
   mojom.UINT32:       "U",
   mojom.FLOAT:        "f",
   mojom.UINT64:       "ULL",
 }
 
 # TODO(rockot): Get rid of these globals. This requires some refactoring of the
 # generator library code so that filters can use the generator as context.
 _current_typemap = {}
 _for_blink = False
+# TODO(rockot, yzshen): The variant handling is kind of a hack currently. Make
+# it right.
+_variant = None
 
 
 def ConstantValue(constant):
   return ExpressionToText(constant.value, kind=constant.kind)
 
 def DefaultValue(field):
   if field.default:
     if mojom.IsStructKind(field.kind):
       assert field.default == "default"
       return "%s::New()" % GetNameForKind(field.kind)
     return ExpressionToText(field.default, kind=field.kind)
   if mojom.IsArrayKind(field.kind) or mojom.IsMapKind(field.kind):
     return "nullptr";
   if mojom.IsStringKind(field.kind):
     return "" if _for_blink else "nullptr"
   return ""
 
 def NamespaceToArray(namespace):
   return namespace.split(".") if namespace else []
 
-def GetNamePartsForKind(kind, add_same_module_namespaces, internal):
+def GetNamePartsForKind(kind, add_same_module_namespaces, add_variant,
+                        internal):
   def MapKindName_(kind):
     if not internal:
       return kind.name
     if mojom.IsStructKind(kind) and kind.native_only:
       return "mojo::Array_Data<uint8_t>"
     if (mojom.IsStructKind(kind) or mojom.IsUnionKind(kind) or
         mojom.IsInterfaceKind(kind) or mojom.IsEnumKind(kind)):
       return kind.name + "_Data"
     return kind.name
 
   parts = []
   if kind.imported_from:

[Sam McNally, 2016/03/17 17:37:58]

We'll want to add the variant here too, but it can wait until variant imports
work.

[yzshen1, 2016/03/17 17:46:36]

Right. I know that part is incorrect currently. To fix that more fundamental
changes are necessary: we either need to assume all imported kinds are using the
same variant; or carry over the variant information if the kind actually is from
a different target which has variant specified.

     parts.extend(NamespaceToArray(kind.imported_from["namespace"]))
-  elif hasattr(kind, "module") and add_same_module_namespaces:
-    parts.extend(NamespaceToArray(kind.module.namespace))
+  elif add_same_module_namespaces:
+    if hasattr(kind, "module"):

[Sam McNally, 2016/03/17 17:37:58]

I don't think it makes sense to add the variant if we aren't adding a namespace
because the kind doesn't have a module.

[yzshen1, 2016/03/17 17:46:36]

I am not quite sure I have understood the problem:
Here |add_same_module_namespaces| basically mean whether we want to add the
namespaces beginning from  what is defined by the "module" definition in mojom.
If not, this method just produces <kind name>, or internal::<kind name>.
Otherwise, we will need to add the variant, right?

[Sam McNally, 2016/03/17 17:52:55]

Yes, but if kind.module doesn't exist when |add_same_module_namespaces| and
|add_variant| are true, we'll be returning just <variant>::<kind name> or
<variant>::internal::<kind name>.

+      parts.extend(NamespaceToArray(kind.module.namespace))
+    if _variant and add_variant:
+      parts.append(_variant)
   if internal:
     parts.append("internal")
   if kind.parent_kind:
     parts.append(MapKindName_(kind.parent_kind))
   parts.append(MapKindName_(kind))
   return parts
 
 def GetNameForKind(kind, internal=False):
-  parts = GetNamePartsForKind(kind, False, internal)
+  parts = GetNamePartsForKind(kind, False, False, internal)
   return "::".join(parts)
 
 def GetQualifiedNameForKind(kind, internal=False):
   # Always start with an empty part to force a leading "::" on output.
   parts = [""]
-  parts.extend(GetNamePartsForKind(kind, True, internal))
+  parts.extend(GetNamePartsForKind(kind, True, True, internal))
   return "::".join(parts)
 
 def GetFullMojomNameForKind(kind):
-  parts = GetNamePartsForKind(kind, True, False)
+  parts = GetNamePartsForKind(kind, True, False, False)
   return ".".join(parts)
 
 def IsTypemappedKind(kind):
   return hasattr(kind, "name") and \
       GetFullMojomNameForKind(kind) in _current_typemap
 
 def IsCloneableKind(kind):
   return mojom.IsCloneableKind(kind, IsTypemappedKind)
 
 def IsNativeOnlyKind(kind):
@@ skipping 438 matching lines @@
 
   @UseJinja("module.cc.tmpl")
   def GenerateModuleSource(self):
     return self.GetJinjaExports()
 
   def GenerateFiles(self, args):
     global _current_typemap
     _current_typemap = self.typemap
     global _for_blink
     _for_blink = self.for_blink
+    global _variant
+    _variant = self.variant
     suffix = "-%s" % self.variant if self.variant else ""
     self.Write(self.GenerateModuleHeader(),
         self.MatchMojomFilePath("%s%s.h" % (self.module.name, suffix)))
     self.Write(self.GenerateModuleInternalHeader(),
         self.MatchMojomFilePath("%s%s-internal.h" % (self.module.name, suffix)))
     self.Write(self.GenerateModuleSource(),
         self.MatchMojomFilePath("%s%s.cc" % (self.module.name, suffix)))