Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

Issue 1811853002: [DevTools] Move evaluateOnCallFrame to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
index 0f330b03df91f6afd95e89a5edb5cf0f5505e784..1b46203821779712261bac537c01c412a7ec810f 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
@@ -37,6 +37,7 @@
namespace blink {
+class InjectedScript;
class InjectedScriptManager;
class V8DebuggerImpl;
@@ -128,9 +129,19 @@ public:
void addInspectedObject(PassOwnPtr<Inspectable>) override;
void clearInspectedObjects() override;
-private:
- PassOwnPtr<protocol::Runtime::ExceptionDetails> createExceptionDetails(v8::Isolate*, v8::Local<v8::Message>);
+ static void wrapEvaluateResult(ErrorString*,
+ V8Debugger*,
+ InjectedScript*,
+ v8::Local<v8::Value> resultValue,
+ v8::TryCatch&,
+ const String16& objectGroup,
+ bool returnByValue,
+ bool generatePreview,
+ OwnPtr<protocol::Runtime::RemoteObject>* result,
+ Maybe<bool>* wasThrown,
+ Maybe<protocol::Runtime::ExceptionDetails>*);
+private:
int m_contextGroupId;
protocol::DictionaryValue* m_state;
protocol::Frontend::Runtime* m_frontend;

Powered by Google App Engine
This is Rietveld 408576698