Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

Issue 1811853002: [DevTools] Move evaluateOnCallFrame to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 722 matching lines...) Expand 10 before | Expand all | Expand 10 after
733 733
734 /** 734 /**
735 * @param {?Protocol.Error} error 735 * @param {?Protocol.Error} error
736 * @param {!RuntimeAgent.RemoteObject} result 736 * @param {!RuntimeAgent.RemoteObject} result
737 * @param {boolean=} wasThrown 737 * @param {boolean=} wasThrown
738 * @this {WebInspector.RemoteObject} 738 * @this {WebInspector.RemoteObject}
739 */ 739 */
740 function evaluatedCallback(error, result, wasThrown) 740 function evaluatedCallback(error, result, wasThrown)
741 { 741 {
742 if (error || wasThrown) { 742 if (error || wasThrown) {
743 callback(error || result.description); 743 callback(error || (result.type !== "string" ? result.description : /** @type {string} */(result.value)));
744 return; 744 return;
745 } 745 }
746 746
747 if (typeof name === "string") 747 if (typeof name === "string")
748 name = WebInspector.RemoteObject.toCallArgument(name); 748 name = WebInspector.RemoteObject.toCallArgument(name);
749 749
750 this.doSetObjectPropertyValue(result, name, callback); 750 this.doSetObjectPropertyValue(result, name, callback);
751 751
752 if (result.objectId) 752 if (result.objectId)
753 this._runtimeAgent.releaseObject(result.objectId); 753 this._runtimeAgent.releaseObject(result.objectId);
(...skipping 875 matching lines...) Expand 10 before | Expand all | Expand 10 after
1629 { 1629 {
1630 if (!this._cachedDescription) { 1630 if (!this._cachedDescription) {
1631 var children = this._children(); 1631 var children = this._children();
1632 this._cachedDescription = "{" + this._formatValue(children[0].value) + " => " + this._formatValue(children[1].value) + "}"; 1632 this._cachedDescription = "{" + this._formatValue(children[0].value) + " => " + this._formatValue(children[1].value) + "}";
1633 } 1633 }
1634 return this._cachedDescription; 1634 return this._cachedDescription;
1635 }, 1635 },
1636 1636
1637 __proto__: WebInspector.LocalJSONObject.prototype 1637 __proto__: WebInspector.LocalJSONObject.prototype
1638 } 1638 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698