Show max latency on client's status bar

remoting/protocol/performance_tracker.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_PERFORMANCE_TRACKER_H_
 #define REMOTING_PROTOCOL_PERFORMANCE_TRACKER_H_
 
 #include <stdint.h>
 
 #include <map>
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/timer/timer.h"
 #include "remoting/base/rate_counter.h"
-#include "remoting/base/running_average.h"
+#include "remoting/base/running_samples.h"
 
 namespace remoting {
 
 class VideoPacket;
 
 namespace protocol {
 
 // PerformanceTracker defines a bundle of performance counters and statistics
 // for chromoting.
 class PerformanceTracker {
@@ skipping 21 matching lines @@
   // Return rates and running-averages for different metrics.
   double video_bandwidth() { return video_bandwidth_.Rate(); }
   double video_frame_rate() { return video_frame_rate_.Rate(); }
   double video_packet_rate() { return video_packet_rate_.Rate(); }
   double video_capture_ms() { return video_capture_ms_.Average(); }
   double video_encode_ms() { return video_encode_ms_.Average(); }
   double video_decode_ms() { return video_decode_ms_.Average(); }
   double video_paint_ms() { return video_paint_ms_.Average(); }
   double round_trip_ms() { return round_trip_ms_.Average(); }
 
+  // Return running-maxes for latencies
+  int64_t max_video_capture_ms() { return video_capture_ms_.Max(); }

[Sergey Ulanov, 2016/03/18 19:42:06]

Update the functions above to return RunningSamples (by const reference). Then
you wouldn't need this function.

[Yuwei, 2016/03/18 20:06:00]

Acknowledged.

+  int64_t max_video_encode_ms() { return video_encode_ms_.Max(); }
+  int64_t max_video_decode_ms() { return video_decode_ms_.Max(); }
+  int64_t max_video_paint_ms() { return video_paint_ms_.Max(); }
+  int64_t max_round_trip_ms() { return round_trip_ms_.Max(); }
+
   // Record stats for a video-packet.
   void RecordVideoPacketStats(const VideoPacket& packet);
 
   // Helpers to track decode and paint time. If the render drops some frames
   // before they are painted then OnFramePainted() records paint time when the
   // following frame is rendered. OnFramePainted() may be called multiple times,
   // in which case all calls after the first one are ignored.
   void OnFrameDecoded(int32_t frame_id);
   void OnFramePainted(int32_t frame_id);
 
@@ skipping 38 matching lines @@
 
   // Video packets per second, including empty video-packets.
   // This will be greater than the frame rate, as individual frames are
   // contained in packets, some of which might be empty (e.g. when there are no
   // screen changes).
   RateCounter video_packet_rate_;
 
   // The following running-averages are uploaded to UMA per video packet and
   // also used for display to users, averaged over the N most recent samples.
   // N = kLatencySampleSize.
-  RunningAverage video_capture_ms_;
-  RunningAverage video_encode_ms_;
-  RunningAverage video_decode_ms_;
-  RunningAverage video_paint_ms_;
-  RunningAverage round_trip_ms_;
+  RunningSamples video_capture_ms_;
+  RunningSamples video_encode_ms_;
+  RunningSamples video_decode_ms_;
+  RunningSamples video_paint_ms_;
+  RunningSamples round_trip_ms_;
 
   // Used to update UMA stats, if set.
   UpdateUmaCustomHistogramCallback uma_custom_counts_updater_;
   UpdateUmaCustomHistogramCallback uma_custom_times_updater_;
   UpdateUmaEnumHistogramCallback uma_enum_histogram_updater_;
 
   // The latest event timestamp that a VideoPacket was seen annotated with.
   base::TimeTicks latest_event_timestamp_;
 
   // Stores timestamps for the frames that are currently being processed.
   FramesTimestampsMap frame_timestamps_;
 
   bool is_paused_ = false;
 
   base::RepeatingTimer upload_uma_stats_timer_;
 
   DISALLOW_COPY_AND_ASSIGN(PerformanceTracker);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_PERFORMANCE_TRACKER_H_