Show max latency on client's status bar

remoting/protocol/performance_tracker.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/performance_tracker.h"
 
 #include "remoting/proto/video.pb.h"
 
 namespace {
 
@@ skipping 72 matching lines @@
 PerformanceTracker::PerformanceTracker()
     : video_bandwidth_(base::TimeDelta::FromSeconds(kStatsUpdatePeriodSeconds)),
       video_frame_rate_(
           base::TimeDelta::FromSeconds(kStatsUpdatePeriodSeconds)),
       video_packet_rate_(
           base::TimeDelta::FromSeconds(kStatsUpdatePeriodSeconds)),
       video_capture_ms_(kLatencySampleSize),
       video_encode_ms_(kLatencySampleSize),
       video_decode_ms_(kLatencySampleSize),
       video_paint_ms_(kLatencySampleSize),
-      round_trip_ms_(kLatencySampleSize) {
+      round_trip_ms_(kLatencySampleSize),
+      max_round_trip_ms_(kLatencySampleSize) {
   uma_custom_counts_updater_ = base::Bind(&UpdateUmaCustomHistogramStub);
   uma_custom_times_updater_ = base::Bind(&UpdateUmaCustomHistogramStub);
   uma_enum_histogram_updater_ = base::Bind(&UpdateUmaEnumHistogramStub);
 }
 
 PerformanceTracker::~PerformanceTracker() {}
 
 void PerformanceTracker::SetUpdateUmaCallbacks(
     UpdateUmaCustomHistogramCallback update_uma_custom_counts_callback,
     UpdateUmaCustomHistogramCallback update_uma_custom_times_callback,
@@ skipping 143 matching lines @@
 void PerformanceTracker::RecordRoundTripLatency(
     const FrameTimestamps& timestamps) {
   if (timestamps.latest_event_timestamp.is_null())
     return;
 
   base::TimeTicks now = base::TimeTicks::Now();
   base::TimeDelta round_trip_latency =
       now - timestamps.latest_event_timestamp;
 
   round_trip_ms_.Record(round_trip_latency.InMilliseconds());
+  max_round_trip_ms_.Record(round_trip_latency.InMilliseconds());

[Sergey Ulanov, 2016/03/17 19:12:37]

If you use the same class for Average() and Max() then the same value will not
need to be recorded in two places, like this.

[Yuwei, 2016/03/17 20:24:44]

Acknowledged.

   uma_custom_times_updater_.Run(
       kRoundTripLatencyHistogram, round_trip_latency.InMilliseconds(),
       kLatencyHistogramMinMs, kLatencyHistogramMaxMs, kLatencyHistogramBuckets);
 
   if (!timestamps.total_host_latency.is_max()) {
     // Calculate total processing time on host and client.
     base::TimeDelta total_processing_latency =
         timestamps.total_host_latency + (now - timestamps.time_received);
     base::TimeDelta network_latency =
         round_trip_latency - total_processing_latency;
@@ skipping 18 matching lines @@
   is_paused_ = paused;
   if (is_paused_) {
     // Pause the UMA timer when the video is paused. It will be unpaused in
     // RecordVideoPacketStats() when a new frame is received.
     upload_uma_stats_timer_.Stop();
   }
 }
 
 }  // namespace protocol
 }  // namespace remoting