Show max latency on client's status bar

remoting/base/running_max.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef REMOTING_BASE_RUNNING_AVERAGE_H_
-#define REMOTING_BASE_RUNNING_AVERAGE_H_
+#ifndef REMOTING_BASE_RUNNING_MAX_H_
+#define REMOTING_BASE_RUNNING_MAX_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <deque>
 
 #include "base/macros.h"
 #include "base/threading/thread_checker.h"
 
 namespace remoting {
 
-// Calculates the average of the most recent N recorded samples.
+// Calculates the maximum of the most recent N recorded samples.
 // This is typically used to smooth out random variation in point samples
 // over bandwidth, frame rate, etc.
-class RunningAverage {
+class RunningMax {

[Sergey Ulanov, 2016/03/17 19:12:37]

I don't think we really need both RunningAverage class and RunningMax. Instead
it would be better to have a single class that host last N samples for the value
and can return both average and max. Just add Max() in RunningAverage, and maybe
rename that class?

[Yuwei, 2016/03/17 20:24:44]

Adding Max() to RunningAverage without renaming the class may be the safest
approach, but the name will be slightly confusing...

For renaming the class, I'm slightly concern about the dependency/compatibility
issue. Is this something we need to concern about?

[Sergey Ulanov, 2016/03/17 22:00:26]

Not sure what's the concern about. The class shouldn't be used outside of
chromium if that's what you are worried about.

[Yuwei, 2016/03/17 23:02:39]

Cool... Will rename it to RunningSample

  public:
-  // Constructs a helper to average over the |window_size| most recent samples.
-  explicit RunningAverage(int window_size);
-  virtual ~RunningAverage();
+  // Constructs a helper to find max over the |window_size| most recent samples.
+  explicit RunningMax(int window_size);
+  virtual ~RunningMax();
 
   // Records a point sample.
   void Record(int64_t value);
 
-  // Returns the average over up to |window_size| of the most recent samples.
-  double Average();
+  // Returns the max over up to |window_size| of the most recent samples.
+  int64_t Max();
 
  private:
   // Stores the desired window size, as size_t to avoid casting when comparing
   // with the size of |data_points_|.
   const size_t window_size_;
 
   // Stores the |window_size| most recently recorded samples.
   std::deque<int64_t> data_points_;
 
-  // Holds the sum of the samples in |data_points_|.
-  int64_t sum_;
-
   base::ThreadChecker thread_checker_;
 
-  DISALLOW_COPY_AND_ASSIGN(RunningAverage);
+  DISALLOW_COPY_AND_ASSIGN(RunningMax);
 };
 
 }  // namespace remoting
 
-#endif  // REMOTING_BASE_RUNNING_AVERAGE_H_
+#endif  // REMOTING_BASE_RUNNING_MAX_H_