Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 181183007: Merged r19591, r19599 into trunk branch. (Closed)

Created:
6 years, 9 months ago by Hannes Payer (out of office)
Modified:
6 years, 9 months ago
Reviewers:
danno-g, danno
CC:
v8-dev
Visibility:
Public.

Description

Merged r19591, r19599 into trunk branch. HAllocate should never generate allocation code if the requested size does not fit into page. Regression test included. Fix representation generalization for doubles. BUG=347543 LOG=N R=danno@google.com, danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19623

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -23 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/property-details.h View 1 chunk +1 line, -1 line 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +5 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-347909.js View 1 chunk +10 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
6 years, 9 months ago (2014-02-28 14:24:24 UTC) #1
danno-g
Rubber stamp LGTM
6 years, 9 months ago (2014-02-28 14:25:01 UTC) #2
Hannes Payer (out of office)
Committed patchset #1 manually as r19623.
6 years, 9 months ago (2014-02-28 14:28:33 UTC) #3
danno
6 years, 9 months ago (2014-02-28 14:29:33 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698