Settings People Revamp: Easy Unlock: Add browsertests.

Settings People Revamp: Easy Unlock: Add browsertests.

BUG=563721
Committed: https://crrev.com/d81c4119aeeae0b695323b3e0308e4c577efb63c
Cr-Commit-Position: refs/heads/master@{#381885}

[Dan Beam, 2016-03-17 01:51:28]

https://codereview.chromium.org/1811813002/diff/1/chrome/test/data/webui/sett...
File chrome/test/data/webui/settings/easy_unlock_browsertest_chromeos.js
(right):

https://codereview.chromium.org/1811813002/diff/1/chrome/test/data/webui/sett...
chrome/test/data/webui/settings/easy_unlock_browsertest_chromeos.js:86:
assertTrue(loadTimeData.valueExists('easyUnlockAllowed'));
yes, this is OK, but why not make this part of your browser proxy?

[tommycli, 2016-03-17 20:22:50]

Patchset #4 (id:60001) has been deleted

[tommycli, 2016-03-17 20:23:10]

tommycli@chromium.org changed reviewers:
+ dpapad@chromium.org

[tommycli, 2016-03-17 20:23:11]

dpapad: PTAL, thanks!

dbeam: Thanks, see below for response

https://codereview.chromium.org/1811813002/diff/1/chrome/test/data/webui/sett...
File chrome/test/data/webui/settings/easy_unlock_browsertest_chromeos.js
(right):

https://codereview.chromium.org/1811813002/diff/1/chrome/test/data/webui/sett...
chrome/test/data/webui/settings/easy_unlock_browsertest_chromeos.js:86:
assertTrue(loadTimeData.valueExists('easyUnlockAllowed'));
On 2016/03/17 01:51:28, Dan Beam wrote:
> yes, this is OK, but why not make this part of your browser proxy?

Done. I just removed this. I don't think it's necessary any more.

[tommycli, 2016-03-17 20:23:48]

tommycli@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[tommycli, 2016-03-17 20:23:49]

phajdan.jr - PTAL BUILD.gn change. thanks!

[dpapad, 2016-03-17 20:45:15]

lgtm

[tommycli, 2016-03-17 22:15:11]

dpapad: thanks for the speedy review!

[tommycli, 2016-03-17 23:39:17]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-03-17 23:39:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 23:39:47]

This CL has an open dependency (Issue 1806123002 Patch 40001). Please resolve
the dependency and try again.

[tommycli, 2016-03-18 00:57:52]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 00:58:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811813002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811813002/40001

[commit-bot: I haz the power, 2016-03-18 01:40:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 01:40:40]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2016-03-18 02:07:30]

LGTM

[tommycli, 2016-03-18 03:47:21]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-03-18 03:47:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811813002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811813002/40001

[commit-bot: I haz the power, 2016-03-18 04:51:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-18 04:54:29]

Description was changed from

==========
Settings People Revamp: Easy Unlock: Add browsertests.

BUG=563721
==========

to

==========
Settings People Revamp: Easy Unlock: Add browsertests.

BUG=563721

Committed: https://crrev.com/d81c4119aeeae0b695323b3e0308e4c577efb63c
Cr-Commit-Position: refs/heads/master@{#381885}
==========

[commit-bot: I haz the power, 2016-03-18 04:54:30]

Patchset 3 (id:??) landed as
https://crrev.com/d81c4119aeeae0b695323b3e0308e4c577efb63c
Cr-Commit-Position: refs/heads/master@{#381885}