kThemePackVersion comment should mention theme cache flushing.

kThemePackVersion comment should mention theme cache flushing.

The comment should mention that bumping the version also flushes the
theme cache. I had intended to add that with my recent change but it
slipped my mind. Having the mentioned explicitly would have helped me
when working on the theme regression that needed the version number bump.

BUG=595510
Committed: https://crrev.com/9845d25e5ab228c1a4203817c419f3156bba90a4
Cr-Commit-Position: refs/heads/master@{#381835}

[shrike, 2016-03-17 00:32:37]

Description was changed from

==========
kThemePackVersion comment should mention theme cache flushing.

The comment should mention that bumping the version also flushes the
theme cache. I had intended to add that with my recent change but it
slipped my mind. Having the mentioned explicitly would have helped me
when working on the theme regression that needed the version number bump.

BUG=595510
==========

to

==========
kThemePackVersion comment should mention theme cache flushing.

The comment should mention that bumping the version also flushes the
theme cache. I had intended to add that with my recent change but it
slipped my mind. Having the mentioned explicitly would have helped me
when working on the theme regression that needed the version number bump.

BUG=595510
==========

[shrike, 2016-03-17 00:32:38]

shrike@chromium.org changed reviewers:
+ estade@chromium.org

[shrike, 2016-03-17 00:32:46]

PTAL

[Evan Stade, 2016-03-17 01:05:39]

lgtm

[Evan Stade, 2016-03-17 01:06:51]

https://codereview.chromium.org/1811803002/diff/1/chrome/browser/themes/brows...
File chrome/browser/themes/browser_theme_pack.cc (right):

https://codereview.chromium.org/1811803002/diff/1/chrome/browser/themes/brows...
chrome/browser/themes/browser_theme_pack.cc:51: // change default theme assets
or otherwise need to flush the theme image cache.
actually the "cache" is a bit vague here. Can we say something like "or if you
need themes to recreate their generated images."

[shrike, 2016-03-17 20:59:15]

https://codereview.chromium.org/1811803002/diff/1/chrome/browser/themes/brows...
File chrome/browser/themes/browser_theme_pack.cc (right):

https://codereview.chromium.org/1811803002/diff/1/chrome/browser/themes/brows...
chrome/browser/themes/browser_theme_pack.cc:51: // change default theme assets
or otherwise need to flush the theme image cache.
On 2016/03/17 01:06:51, Evan Stade wrote:
> actually the "cache" is a bit vague here. Can we say something like "or if you
> need themes to recreate their generated images."

I'm OK with that, except I think it should explicitly mention that these images
are cached. Please let me know what you think of my edit.

[Evan Stade, 2016-03-17 21:06:59]

super

[shrike, 2016-03-17 21:08:15]

The CQ bit was checked by shrike@chromium.org

[shrike, 2016-03-17 21:08:15]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1811803002/#ps20001
(title: "Tweak comment.")

[commit-bot: I haz the power, 2016-03-17 21:08:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811803002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811803002/20001

[commit-bot: I haz the power, 2016-03-17 21:11:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 21:11:36]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[shrike, 2016-03-17 21:18:33]

The CQ bit was checked by shrike@chromium.org

[shrike, 2016-03-17 21:18:33]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1811803002/#ps40001
(title: "Rebase against ToT.")

[commit-bot: I haz the power, 2016-03-17 21:19:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811803002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811803002/40001

[commit-bot: I haz the power, 2016-03-17 23:32:51]

Description was changed from

==========
kThemePackVersion comment should mention theme cache flushing.

The comment should mention that bumping the version also flushes the
theme cache. I had intended to add that with my recent change but it
slipped my mind. Having the mentioned explicitly would have helped me
when working on the theme regression that needed the version number bump.

BUG=595510
==========

to

==========
kThemePackVersion comment should mention theme cache flushing.

The comment should mention that bumping the version also flushes the
theme cache. I had intended to add that with my recent change but it
slipped my mind. Having the mentioned explicitly would have helped me
when working on the theme regression that needed the version number bump.

BUG=595510
==========

[commit-bot: I haz the power, 2016-03-17 23:32:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-17 23:34:31]

Description was changed from

==========
kThemePackVersion comment should mention theme cache flushing.

The comment should mention that bumping the version also flushes the
theme cache. I had intended to add that with my recent change but it
slipped my mind. Having the mentioned explicitly would have helped me
when working on the theme regression that needed the version number bump.

BUG=595510
==========

to

==========
kThemePackVersion comment should mention theme cache flushing.

The comment should mention that bumping the version also flushes the
theme cache. I had intended to add that with my recent change but it
slipped my mind. Having the mentioned explicitly would have helped me
when working on the theme regression that needed the version number bump.

BUG=595510

Committed: https://crrev.com/9845d25e5ab228c1a4203817c419f3156bba90a4
Cr-Commit-Position: refs/heads/master@{#381835}
==========

[commit-bot: I haz the power, 2016-03-17 23:34:33]

Patchset 3 (id:??) landed as
https://crrev.com/9845d25e5ab228c1a4203817c419f3156bba90a4
Cr-Commit-Position: refs/heads/master@{#381835}