Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1811753004: Webkit/Source/web/WebLocalFrameImpl microcleanup (Closed)

Created:
3 years, 11 months ago by mcasas
Modified:
3 years, 11 months ago
Reviewers:
esprehn, dcheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Webkit/Source/web/WebLocalFrameImpl microcleanup Cleanup, no new code: - early return in the method - removed {} for one-line bodies, following the style of the method. (stumbled upon this in http://crrev.com/1794553002) Committed: https://crrev.com/8f5eb4c1ae4cfea73a9886f6e4cc361e5373a5ab Cr-Commit-Position: refs/heads/master@{#382014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -35 lines) Patch
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +34 lines, -35 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
mcasas
dcheng@ PTAL (just refactored a few lines)
3 years, 11 months ago (2016-03-17 21:03:05 UTC) #3
mcasas
adding esprehn@ - tiny reindenting, RS pls
3 years, 11 months ago (2016-03-18 17:32:06 UTC) #5
esprehn
lgtm
3 years, 11 months ago (2016-03-18 17:46:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811753004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811753004/1
3 years, 11 months ago (2016-03-18 17:58:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-03-18 18:04:43 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8f5eb4c1ae4cfea73a9886f6e4cc361e5373a5ab Cr-Commit-Position: refs/heads/master@{#382014}
3 years, 11 months ago (2016-03-18 18:05:47 UTC) #12
dcheng
3 years, 11 months ago (2016-03-18 18:17:46 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698