Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 1811753003: Set m_{width,height}AvailableToChildrenChanged when scrollbars appear (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: different/better approach Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableCell.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@gmail.com> 9 * Christian Biesinger <cbiesinger@gmail.com>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 663 matching lines...) Expand 10 before | Expand all | Expand 10 after
674 674
675 // Force an update since we know the scrollbars have changed things. 675 // Force an update since we know the scrollbars have changed things.
676 if (box().document().hasAnnotatedRegions()) 676 if (box().document().hasAnnotatedRegions())
677 box().document().setAnnotatedRegionsDirty(true); 677 box().document().setAnnotatedRegionsDirty(true);
678 678
679 // Our proprietary overflow: overlay value doesn't trigger a layout. 679 // Our proprietary overflow: overlay value doesn't trigger a layout.
680 if ((horizontalScrollBarChanged && box().style()->overflowX() != Overflo wOverlay) || (verticalScrollBarChanged && box().style()->overflowY() != Overflow Overlay)) { 680 if ((horizontalScrollBarChanged && box().style()->overflowX() != Overflo wOverlay) || (verticalScrollBarChanged && box().style()->overflowY() != Overflow Overlay)) {
681 if (!m_inOverflowRelayout) { 681 if (!m_inOverflowRelayout) {
682 m_inOverflowRelayout = true; 682 m_inOverflowRelayout = true;
683 if (delayedLayoutScope) { 683 if (delayedLayoutScope) {
684 if (box().isLayoutBlock()) {
685 LayoutBlock& block = toLayoutBlock(box());
686 block.scrollbarsChanged(horizontalScrollBarChanged, vert icalScrollBarChanged);
mstensho (USE GERRIT) 2016/03/18 19:04:26 I'm not going to complain if you squash this into
cbiesinger 2016/03/18 19:13:47 Done.
687 }
684 delayedLayoutScope->setNeedsLayout(&box(), LayoutInvalidatio nReason::ScrollbarChanged); 688 delayedLayoutScope->setNeedsLayout(&box(), LayoutInvalidatio nReason::ScrollbarChanged);
685 didMarkForDelayedLayout = true; 689 didMarkForDelayedLayout = true;
686 } else { 690 } else {
687 SubtreeLayoutScope layoutScope(box()); 691 SubtreeLayoutScope layoutScope(box());
688 layoutScope.setNeedsLayout(&box(), LayoutInvalidationReason: :ScrollbarChanged); 692 layoutScope.setNeedsLayout(&box(), LayoutInvalidationReason: :ScrollbarChanged);
689 if (box().isLayoutBlock()) { 693 if (box().isLayoutBlock()) {
690 LayoutBlock& block = toLayoutBlock(box()); 694 LayoutBlock& block = toLayoutBlock(box());
691 block.scrollbarsChanged(horizontalScrollBarChanged, vert icalScrollBarChanged); 695 block.scrollbarsChanged(horizontalScrollBarChanged, vert icalScrollBarChanged);
692 block.layoutBlock(true); 696 block.layoutBlock(true);
693 } else { 697 } else {
(...skipping 889 matching lines...) Expand 10 before | Expand all | Expand 10 after
1583 } 1587 }
1584 1588
1585 DEFINE_TRACE(PaintLayerScrollableArea::ScrollbarManager) 1589 DEFINE_TRACE(PaintLayerScrollableArea::ScrollbarManager)
1586 { 1590 {
1587 visitor->trace(m_scrollableArea); 1591 visitor->trace(m_scrollableArea);
1588 visitor->trace(m_hBar); 1592 visitor->trace(m_hBar);
1589 visitor->trace(m_vBar); 1593 visitor->trace(m_vBar);
1590 } 1594 }
1591 1595
1592 } // namespace blink 1596 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableCell.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698