third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes.html - Issue 1811753003: Set m_{width,height}AvailableToChildrenChanged when scrollbars appear

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes.html

Issue 1811753003: Set m_{width,height}AvailableToChildrenChanged when scrollbars appear (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add a test (minimized from trace viewer) Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-expected.html » ('j') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>This test should not have a horizontal scrollbar</title>
	mstensho (USE GERRIT) 2016/03/17 19:57:06 I think we usually put the pass condition as reada I think we usually put the pass condition as readable text in the document, i.e. put it in a <p> or something.
	3 <html>
	mstensho (USE GERRIT) 2016/03/17 19:57:06 Wrong order. HTML should contain TITLE. But bette Wrong order. HTML should contain TITLE. But better just omit the HTML and HEAD tags instead. Normally BODY too, but in this case you set class names on it, so fine.
	4

	5 <style>

	6 body {

	7 width: 400px;

	8 height: 300px;

	9 }

	10

	11 .flexbox {

	12 display: flex;

	13 }

	14

	15 .column {

	16 flex-direction: column;

	17 }

	18

	19 .flex11a {

	20 flex: 1 1 auto;

	21 }

	22

	23 .root {

	24 height: 100px;

	25 overflow-y: auto;

	26 }

	27 </style>

	28 </head>

	29 <body class="flexbox column">

	30

	31 <div class="flexbox">

	32 <div class="flex11a">

	33 <div id="root" class="root">

	34 <div id="history"></div>

	35 </div>

	36 </div>

	37 </div>

	38

	39 <script>

	40 onload = function() {

	41 var historyEl = document.getElementById('history');

	42 historyEl.offsetWidth;

	43 historyEl.innerText = '\n\n\n\n\n\n\n\n';

	44 };

	45 </script>

	46

	47 </body>

	48 </html>

OLD	NEW