Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableCell.cpp

Issue 1811753003: Set m_{width,height}AvailableToChildrenChanged when scrollbars appear (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comment Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 958 matching lines...) Expand 10 before | Expand all | Expand 10 after
969 TableCellPainter(*this).paintMask(paintInfo, paintOffset); 969 TableCellPainter(*this).paintMask(paintInfo, paintOffset);
970 } 970 }
971 971
972 bool LayoutTableCell::boxShadowShouldBeAppliedToBackground(BackgroundBleedAvoida nce, const InlineFlowBox*) const 972 bool LayoutTableCell::boxShadowShouldBeAppliedToBackground(BackgroundBleedAvoida nce, const InlineFlowBox*) const
973 { 973 {
974 return false; 974 return false;
975 } 975 }
976 976
977 void LayoutTableCell::scrollbarsChanged(bool horizontalScrollbarChanged, bool ve rticalScrollbarChanged) 977 void LayoutTableCell::scrollbarsChanged(bool horizontalScrollbarChanged, bool ve rticalScrollbarChanged)
978 { 978 {
979 LayoutBlock::scrollbarsChanged(horizontalScrollbarChanged, verticalScrollbar Changed);
979 int scrollbarHeight = scrollbarLogicalHeight(); 980 int scrollbarHeight = scrollbarLogicalHeight();
980 if (!scrollbarHeight) 981 if (!scrollbarHeight)
981 return; // Not sure if we should be doing something when a scrollbar goe s away or not. 982 return; // Not sure if we should be doing something when a scrollbar goe s away or not.
982 983
983 // We only care if the scrollbar that affects our intrinsic padding has been added. 984 // We only care if the scrollbar that affects our intrinsic padding has been added.
984 if ((isHorizontalWritingMode() && !horizontalScrollbarChanged) 985 if ((isHorizontalWritingMode() && !horizontalScrollbarChanged)
985 || (!isHorizontalWritingMode() && !verticalScrollbarChanged)) 986 || (!isHorizontalWritingMode() && !verticalScrollbarChanged))
986 return; 987 return;
987 988
988 // Shrink our intrinsic padding as much as possible to accommodate the scrol lbar. 989 // Shrink our intrinsic padding as much as possible to accommodate the scrol lbar.
(...skipping 28 matching lines...) Expand all
1017 bool LayoutTableCell::backgroundIsKnownToBeOpaqueInRect(const LayoutRect& localR ect) const 1018 bool LayoutTableCell::backgroundIsKnownToBeOpaqueInRect(const LayoutRect& localR ect) const
1018 { 1019 {
1019 // If this object has layer, the area of collapsed borders should be transpa rent 1020 // If this object has layer, the area of collapsed borders should be transpa rent
1020 // to expose the collapsed borders painted on the underlying layer. 1021 // to expose the collapsed borders painted on the underlying layer.
1021 if (hasLayer() && table()->collapseBorders()) 1022 if (hasLayer() && table()->collapseBorders())
1022 return false; 1023 return false;
1023 return LayoutBlockFlow::backgroundIsKnownToBeOpaqueInRect(localRect); 1024 return LayoutBlockFlow::backgroundIsKnownToBeOpaqueInRect(localRect);
1024 } 1025 }
1025 1026
1026 } // namespace blink 1027 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698