Source/modules/serviceworkers/WaitUntilObserver.cpp - Issue 181173002: ScriptPromise should check the constructor paraemter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/WaitUntilObserver.cpp

Issue 181173002: ScriptPromise should check the constructor paraemter. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/serviceworkers/WaitUntilObserver.cpp

diff --git a/Source/modules/serviceworkers/WaitUntilObserver.cpp b/Source/modules/serviceworkers/WaitUntilObserver.cpp

index 0d09153d0b41432a8370a29e2e31f6b769a0635c..f239f541f70185976a3e31dc9aab55232ea62e79 100644

--- a/Source/modules/serviceworkers/WaitUntilObserver.cpp

+++ b/Source/modules/serviceworkers/WaitUntilObserver.cpp

@@ -75,7 +75,7 @@ void WaitUntilObserver::didDispatchEvent()

void WaitUntilObserver::waitUntil(const ScriptValue& value)

{

incrementPendingActivity();

- ScriptPromise(value).then(

+ ScriptPromise::cast(value).then(

ThenFunction::create(this, ThenFunction::Fulfilled),

ThenFunction::create(this, ThenFunction::Rejected));

}

« Source/bindings/v8/ScriptPromise.cpp ('K') | « Source/bindings/v8/ScriptPromiseTest.cpp ('k') | no next file » | no next file with comments »