ScriptPromise should check the constructor paraemter.

Source/bindings/v8/ScriptPromiseTest.cpp

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 25 matching lines @@
 #include "bindings/v8/V8Binding.h"
 #include "bindings/v8/custom/V8PromiseCustom.h"
 
 #include <gtest/gtest.h>
 #include <v8.h>
 
 namespace WebCore {
 
 namespace {
 
+void callback(const v8::FunctionCallbackInfo<v8::Value>& info) { }
+
 class ScriptPromiseTest : public testing::Test {
 public:
     ScriptPromiseTest()
         : m_isolate(v8::Isolate::GetCurrent())
         , m_handleScope(m_isolate)
         , m_context(m_isolate, v8::Context::New(m_isolate))
         , m_contextScope(m_context.newLocal(m_isolate))
     {
-    }
-
-    void SetUp()
-    {
         v8::Handle<v8::Context> context(m_context.newLocal(m_isolate));
         V8PerContextDataHolder::install(context, DOMWrapperWorld::current(m_isolate));
         m_perContextData = V8PerContextData::create(context);
         m_perContextData->init();
     }
 
-    void TearDown()
+    ~ScriptPromiseTest()
     {
-        m_perContextData.clear();
+        // FIXME: We put this statement here to clear an exception from the isolate.
+        createClosure(callback, v8::Undefined(m_isolate), m_isolate);
     }
 
     V8PromiseCustom::PromiseState state(ScriptPromise promise)
     {
         return V8PromiseCustom::getState(V8PromiseCustom::getInternal(promise.v8Value().As<v8::Object>()));
     }
 
 protected:
     v8::Isolate* m_isolate;
     v8::HandleScope m_handleScope;
     ScopedPersistent<v8::Context> m_context;
     v8::Context::Scope m_contextScope;
     OwnPtr<V8PerContextData> m_perContextData;
 };
 
+TEST_F(ScriptPromiseTest, constructFromNonPromise)
+{
+    v8::TryCatch trycatch;
+    ScriptPromise promise(v8::Undefined(m_isolate), m_isolate);
+    ASSERT_TRUE(trycatch.HasCaught());
+    ASSERT_TRUE(promise.hasNoValue());
+}
+
 TEST_F(ScriptPromiseTest, castPromise)
 {
     ScriptPromise promise = ScriptPromise::createPending();
-    ScriptPromise newPromise(ScriptValue(promise.v8Value(), m_isolate));
+    ScriptPromise newPromise = ScriptPromise::cast(ScriptValue(promise.v8Value(), m_isolate));
 
     ASSERT_FALSE(promise.hasNoValue());
     EXPECT_EQ(V8PromiseCustom::Pending, state(promise));
     EXPECT_EQ(promise.v8Value(), newPromise.v8Value());
 }
 
 TEST_F(ScriptPromiseTest, castNonPromise)
 {
     ScriptValue value = ScriptValue(v8String(m_isolate, "hello"), m_isolate);
-    ScriptPromise promise1(ScriptValue(value.v8Value(), m_isolate));
-    ScriptPromise promise2(ScriptValue(value.v8Value(), m_isolate));
+    ScriptPromise promise1 = ScriptPromise::cast(ScriptValue(value.v8Value(), m_isolate));
+    ScriptPromise promise2 = ScriptPromise::cast(ScriptValue(value.v8Value(), m_isolate));
 
     ASSERT_FALSE(promise1.hasNoValue());
     ASSERT_FALSE(promise2.hasNoValue());
 
     ASSERT_TRUE(V8PromiseCustom::isPromise(promise1.v8Value(), m_isolate));
     ASSERT_TRUE(V8PromiseCustom::isPromise(promise2.v8Value(), m_isolate));
 
     EXPECT_EQ(V8PromiseCustom::Fulfilled, state(promise1));
     EXPECT_EQ(V8PromiseCustom::Fulfilled, state(promise2));
     EXPECT_NE(promise1.v8Value(), promise2.v8Value());
 }
 
 } // namespace
 
 } // namespace WebCore