runtime/observatory/tests/service/dominator_tree_test.dart - Issue 1811713002: Perform a full GC by default when requesting a heap snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/dominator_tree_test.dart

Issue 1811713002: Perform a full GC by default when requesting a heap snapshot. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/tests/service/dominator_tree_test.dart

diff --git a/runtime/observatory/tests/service/dominator_tree_test.dart b/runtime/observatory/tests/service/dominator_tree_test.dart

index a778f62343d968a15008e366056a0af25df71938..5c279c91263a790d024ee87d7e15766786a3eaac 100644

--- a/runtime/observatory/tests/service/dominator_tree_test.dart

+++ b/runtime/observatory/tests/service/dominator_tree_test.dart

@@ -57,7 +57,7 @@ buildGraph() {

var tests = [

(Isolate isolate) async {

var rootLib = await isolate.rootLibrary.load();

- var snapshot = await isolate.fetchHeapSnapshot().last;

+ var snapshot = await isolate.fetchHeapSnapshot(false).last;

node(String className) {

var cls = rootLib.classes.singleWhere((cls) => cls.name == className);