runtime/observatory/lib/src/elements/class_view.dart - Issue 1811713002: Perform a full GC by default when requesting a heap snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/class_view.dart

Issue 1811713002: Perform a full GC by default when requesting a heap snapshot. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/src/elements/class_view.dart

diff --git a/runtime/observatory/lib/src/elements/class_view.dart b/runtime/observatory/lib/src/elements/class_view.dart

index d50b092a1002de074013c9b2c073de14af5ad1d0..c13cbb36fad03292857b19b3f00c0bbc8090eef5 100644

--- a/runtime/observatory/lib/src/elements/class_view.dart

+++ b/runtime/observatory/lib/src/elements/class_view.dart

@@ -35,7 +35,7 @@ class ClassViewElement extends ObservatoryElement {

}

Future<ServiceObject> retainedToplist(var limit) {

- return cls.isolate.fetchHeapSnapshot().last

+ return cls.isolate.fetchHeapSnapshot(true).last

.then((HeapSnapshot snapshot) =>

Future.wait(snapshot.getMostRetained(classId: cls.vmCid,

limit: 10)))