Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: runtime/vm/object_graph.cc

Issue 1811713002: Perform a full GC by default when requesting a heap snapshot. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object_graph.cc
diff --git a/runtime/vm/object_graph.cc b/runtime/vm/object_graph.cc
index 6c4699778345b30fac3d8b6a0f4c7ffc4006ed9f..145b84e3ef4570e9b12a99950c36390a9f924011 100644
--- a/runtime/vm/object_graph.cc
+++ b/runtime/vm/object_graph.cc
@@ -511,9 +511,13 @@ class WriteGraphVisitor : public ObjectGraph::Visitor {
};
-intptr_t ObjectGraph::Serialize(WriteStream* stream) {
+intptr_t ObjectGraph::Serialize(WriteStream* stream, bool collect_garbage) {
+ if (collect_garbage) {
+ isolate()->heap()->CollectAllGarbage();
+ }
// Current encoding assumes objects do not move, so promote everything to old.
isolate()->heap()->new_space()->Evacuate();
+
WriteGraphVisitor visitor(isolate(), stream);
stream->WriteUnsigned(kObjectAlignment);
stream->WriteUnsigned(0);

Powered by Google App Engine
This is Rietveld 408576698