Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1811713002: Perform a full GC by default when requesting a heap snapshot. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 19a086c4519e48c9eedbfe179345802fecb5fd2c..4fe8aadb885e325e0f8ee913338d665db1664369 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -1365,11 +1365,12 @@ class Isolate extends ServiceObjectOwner {
}
}
- Stream fetchHeapSnapshot() {
+ Stream fetchHeapSnapshot(collectGarbage) {
if (_snapshotFetch == null || _snapshotFetch.isClosed) {
_snapshotFetch = new StreamController();
// isolate.vm.streamListen('_Graph');
- isolate.invokeRpcNoUpgrade('_requestHeapSnapshot', {});
+ isolate.invokeRpcNoUpgrade('_requestHeapSnapshot',
+ {'collectGarbage': collectGarbage});
}
return _snapshotFetch.stream;
}

Powered by Google App Engine
This is Rietveld 408576698