tools/skpmaker.cpp - Issue 1811703002: return pictures as sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skpmaker.cpp

Issue 1811703002: return pictures as sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rely on RVO in picturerecorder Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/skpmaker.cpp

diff --git a/tools/skpmaker.cpp b/tools/skpmaker.cpp

index 8fa969a6f072f2a87dc55ca0088ae5d719d58774..99e6adf997166e1e055851148489a9ef8fcb4a24 100644

--- a/tools/skpmaker.cpp

+++ b/tools/skpmaker.cpp

@@ -41,9 +41,8 @@ static void make_skp(SkScalar width, SkScalar height, SkScalar border, SkColor c

paint.setColor(color);

r.inset(border, border);

canvas->drawRect(r, paint);

- SkAutoTUnref<SkPicture> pict(recorder.endRecording());

SkFILEWStream stream(writePath);

- pict->serialize(&stream);

+ recorder.finishRecordingAsPicture()->serialize(&stream);

}

int tool_main(int argc, char** argv);

« no previous file with comments | « tools/skiaserve/Request.cpp ('k') | no next file » | no next file with comments »