tools/skiaserve/Request.h - Issue 1811703002: return pictures as sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skiaserve/Request.h

Issue 1811703002: return pictures as sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rely on RVO in picturerecorder Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/skiaserve/Request.h

diff --git a/tools/skiaserve/Request.h b/tools/skiaserve/Request.h

index 52ebf25c2f0d0d1a0fce9ca213b551910e89e421..eecfe3357156138c65c4dc9c66651f21c7e0cd35 100644

--- a/tools/skiaserve/Request.h

+++ b/tools/skiaserve/Request.h

@@ -68,7 +68,7 @@ private:

SkIRect getBounds();

GrContext* getContext();

- SkAutoTUnref<SkPicture> fPicture;

+ sk_sp<SkPicture> fPicture;

GrContextFactory* fContextFactory;

SkAutoTUnref<SkSurface> fSurface;

bool fGPUEnabled;

« no previous file with comments | « tools/pinspect.cpp ('k') | tools/skiaserve/Request.cpp » ('j') | no next file with comments »