tools/get_images_from_skps.cpp - Issue 1811703002: return pictures as sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/get_images_from_skps.cpp

Issue 1811703002: return pictures as sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rely on RVO in picturerecorder Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/get_images_from_skps.cpp

diff --git a/tools/get_images_from_skps.cpp b/tools/get_images_from_skps.cpp

index 7d0854d4d4d574359d79e99aa90dcd247f606848..e6bb6e2012190698ebda8359826f7d36be275861 100644

--- a/tools/get_images_from_skps.cpp

+++ b/tools/get_images_from_skps.cpp

@@ -90,7 +90,7 @@ int main(int argc, char** argv) {

for (SkString file; iter.next(&file); ) {

SkAutoTDelete<SkStream> stream =

SkStream::NewFromFile(SkOSPath::Join(inputs, file.c_str()).c_str());

- SkAutoTUnref<SkPicture> picture(SkPicture::CreateFromStream(stream));

+ sk_sp<SkPicture> picture(SkPicture::MakeFromStream(stream));

SkDynamicMemoryWStream scratch;

Sniffer sniff;

« no previous file with comments | « tools/dump_record.cpp ('k') | tools/gpuveto.cpp » ('j') | no next file with comments »