tools/VisualBench/VisualBenchmarkStream.h - Issue 1811703002: return pictures as sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/VisualBench/VisualBenchmarkStream.h

Issue 1811703002: return pictures as sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rely on RVO in picturerecorder Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/VisualBench/VisualBenchmarkStream.h

diff --git a/tools/VisualBench/VisualBenchmarkStream.h b/tools/VisualBench/VisualBenchmarkStream.h

index b1fd0f08c722dbcc60814b80b2ecb7c165809ec9..71b6c972f2baa4509a3bbbf48039966a40aa1480 100644

--- a/tools/VisualBench/VisualBenchmarkStream.h

+++ b/tools/VisualBench/VisualBenchmarkStream.h

@@ -20,7 +20,7 @@ class VisualBenchmarkStream {

public:

VisualBenchmarkStream(const SkSurfaceProps&, bool justSKP = false);

- static bool ReadPicture(const char* path, SkAutoTUnref<SkPicture>* pic);

+ static sk_sp<SkPicture> ReadPicture(const char* path);

Benchmark* next();

Benchmark* current() { return fBenchmark.get(); }

« no previous file with comments | « tests/SkpSkGrTest.cpp ('k') | tools/VisualBench/VisualBenchmarkStream.cpp » ('j') | no next file with comments »