tests/RecordingXfermodeTest.cpp - Issue 1811703002: return pictures as sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/RecordingXfermodeTest.cpp

Issue 1811703002: return pictures as sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rely on RVO in picturerecorder Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/RecordingXfermodeTest.cpp

diff --git a/tests/RecordingXfermodeTest.cpp b/tests/RecordingXfermodeTest.cpp

index 05af84c377e89d98edbf05c9ccd08a67dbf746e9..0f91aea9648589e97bfdd82438555022b90a7433 100644

--- a/tests/RecordingXfermodeTest.cpp

+++ b/tests/RecordingXfermodeTest.cpp

@@ -114,7 +114,7 @@ class PictureStrategy : public RecordingStrategy {

SkIntToScalar(fHeight),

&factory);

drawer.draw(canvas, canvasRect, mode);

- SkAutoTUnref<SkPicture> picture(recorder.endRecording());

+ sk_sp<SkPicture> picture(recorder.finishRecordingAsPicture());

SkCanvas replayCanvas(fBitmap);

replayCanvas.clear(0xffffffff);

« no previous file with comments | « tests/RecordReplaceDrawTest.cpp ('k') | tests/SerializationTest.cpp » ('j') | no next file with comments »