tests/PictureBBHTest.cpp - Issue 1811703002: return pictures as sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PictureBBHTest.cpp

Issue 1811703002: return pictures as sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rely on RVO in picturerecorder Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PictureBBHTest.cpp

diff --git a/tests/PictureBBHTest.cpp b/tests/PictureBBHTest.cpp

index 0a0d3da914b594f1b584a267b6ca2ea2a4708ce0..deb299ae69b51f564e1c197020168c5ca3367172 100644

--- a/tests/PictureBBHTest.cpp

+++ b/tests/PictureBBHTest.cpp

@@ -45,7 +45,7 @@ private:

SkIntToScalar(fPictureHeight),

factory);

this->doTest(playbackCanvas, *recordCanvas);

- SkAutoTUnref<SkPicture> picture(recorder.endRecording());

+ sk_sp<SkPicture> picture(recorder.finishRecordingAsPicture());

playbackCanvas.drawPicture(picture);

REPORTER_ASSERT(reporter, SK_ColorGREEN == fResultBitmap.getColor(0, 0));

}

« no previous file with comments | « tests/PathOpsSkpClipTest.cpp ('k') | tests/PictureShaderTest.cpp » ('j') | no next file with comments »